https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 126789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126789&action=edit Bug 29309: Make 'Pay all fines' be 'Pay all charges' It is not just fines, it is also fees, etc. To test: 1. Have a patron with debt 2. Go to the circulation page for the patron => FAIL: There's a button saying 'Pay all fines' 3. Apply this patch and reload page => SUCCESS: The button now says 'Pay all charges' 4. Enjoy the new terminology 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126789|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 126790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126790&action=edit Bug 29309: Make 'Pay all fines' be 'Pay all charges' It is not just fines, it is also fees, etc. To test: 1. Have a patron with debt 2. Go to the circulation page for the patron => FAIL: There's a button saying 'Pay all fines' 3. Apply this patch and reload page => SUCCESS: The button now says 'Pay all charges' 4. Enjoy the new terminology 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 --- Comment #3 from David Nind <david@davidnind.com> --- I love it when terminology inconsistencies are fixed up! The current message "Checkouts are BLOCKED because fine balance is OVER THE LIMIT" needs fixing as well - I will create a separate bug for that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi from comment #4)

Give me the right wording, and I'll write it as a patch on your behalf, as a follow-up here!

Options to change "Checkouts are BLOCKED because fine balance is OVER THE LIMIT": 1. Checkouts are BLOCKED because the amount owed is OVER THE LIMIT 2. Checkouts are BLOCKED because outstanding charges are OVER THE LIMIT 3. Checkouts are BLOCKED because the amount outstanding is OVER THE LIMIT 4. Checkouts are BLOCKED because the patron's balance is OVER THE LIMIT 5. Checkouts are BLOCKED because the balance for fees and charges is OVER THE LIMIT I prefer option 4. Thanks Tomás! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126790|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 126792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126792&action=edit Bug 29309: Make 'Pay all fines' be 'Pay all charges' It is not just fines, it is also fees, etc. To test: 1. Have a patron with debt 2. Go to the circulation page for the patron => FAIL: There's a button saying 'Pay all fines' 3. Apply this patch and reload page => SUCCESS: The button now says 'Pay all charges' 4. Enjoy the new terminology 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #5)

(In reply to Tomás Cohen Arazi from comment #4)

...

Give me the right wording, and I'll write it as a patch on your behalf, as a follow-up here!

Options to change "Checkouts are BLOCKED because fine balance is OVER THE LIMIT":

1. Checkouts are BLOCKED because the amount owed is OVER THE LIMIT

2. Checkouts are BLOCKED because outstanding charges are OVER THE LIMIT

3. Checkouts are BLOCKED because the amount outstanding is OVER THE LIMIT

4. Checkouts are BLOCKED because the patron's balance is OVER THE LIMIT

5. Checkouts are BLOCKED because the balance for fees and charges is OVER THE LIMIT

I prefer option 4.

Thanks Tomás!

The problem with these, and the original wording too, is that what we block on depends on preferences.. it's not the total outstanding balance, it's a subset of those charges... so we'd need something more generic I think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29309 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.