[Bug 38766] New: Opening, closing, or deleting and invoice from the Action drop-down can cause internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Bug ID: 38766 Summary: Opening, closing, or deleting and invoice from the Action drop-down can cause internal server error Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Depends on: 38155, 38765 The links to perform invoice actions from the Action menu on invoices.pl pass the search url, so that the page can redirect back to the search results after performing the action. This url includes the selected search filter values. However, if dates were used to filter the search, the url includes the dates formatted according to the local DateFormat system preference, instead of ISO format. This causes a parsing error when redirecting back. Similar errors were fixed on bug 38765 and bug 38155. Building this patch on top of those patches, to make it easier to confirm that all such errors in this template have been fixed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 [Bug 38155] Can't close invoices using checkboxes from invoices.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38765 [Bug 38765] Internal server error when merging invoices in invoices.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 --- Comment #1 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 175851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175851&action=edit Bug 38766: Use uri filter for all parameters in referer link Also fixes the confirmation message for deleting. To test: 1. Go to Acquisitions and create some invoices i. Search for a vendor (can submit a blank search box) ii. Click on vendor name iii. Click "Receive shipments" button iv. In the "Receive a new shipment" section, enter any value in the "Vendor invoice" field and click "Next" v. Click the "My Vendor" breadcrumb and repeat iii-iv a few times 2. Go to Acquisitions > Invoices 3. Specify search filters for shipment to/from dates (that include the invoices you entered) and search for invoices 4. Try opening, closing, and deleting individual invoices using the Action menu --> Internal server error! "The given date <date> does not match the date format (iso)". --> Also, note that there is no confirmation dialog when deleting 5. Apply patch 6. Repeat steps 2-4 --> Confirm that invoices can be opened and closed using the drop-down menu with no issue --> Confirm that both open and closed invoices can be deleted with no issue, and that a confirmation message displays before deleting Note for QA: search for $KohaDates within invoices.tt, and confirm that the $KohaDates filter is now only used for display, never for Internal data storage/flow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175851|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 175854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175854&action=edit Bug 38766: Use uri filter for all parameters in referer link Also fixes the confirmation message for deleting. To test: 1. Go to Acquisitions and create some invoices i. Search for a vendor (can submit a blank search box) ii. Click on vendor name iii. Click "Receive shipments" button iv. In the "Receive a new shipment" section, enter any value in the "Vendor invoice" field and click "Next" v. Click the "My Vendor" breadcrumb and repeat iii-iv a few times 2. Go to Acquisitions > Invoices 3. Specify search filters for shipment to/from dates (that include the invoices you entered) and search for invoices 4. Try opening, closing, and deleting individual invoices using the Action menu --> Internal server error! "The given date <date> does not match the date format (iso)". --> Also, note that there is no confirmation dialog when deleting 5. Apply patch 6. Repeat steps 2-4 --> Confirm that invoices can be opened and closed using the drop-down menu with no issue --> Confirm that both open and closed invoices can be deleted with no issue, and that a confirmation message displays before deleting Note for QA: search for $KohaDates within invoices.tt, and confirm that the $KohaDates filter is now only used for display, never for Internal data storage/flow Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've added a follow-up for a transatability issue: data-confirmation-msg="Are you sure you want to delete this invoice? Following the existing pattern: data-confirmation-msg="[% t('...') | html %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes closing and release notes| |reopening of invoices using | |the action button options | |(Acquisitions > [Vendor] > | |Invoices > Actions) - when | |used from the search | |results when using invoice | |filters (for example, | |shipment to and from | |dates). This caused an | |internal server error with | |the message "The given date | |<date> does not match the | |date format (iso)...". It | |also adds a confirmation | |message when deleting an | |invoice. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Todd Goatley <tgoatley@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tgoatley@gmail.com --- Comment #5 from Todd Goatley <tgoatley@gmail.com> --- HI Koha Devs. We have 24.11 early adopter libraries testing and one is reporting this issue. Any chance to get a back port to 24.11? Greatly appreciated! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Bug 38766 depends on bug 38155, which changed state. Bug 38155 Summary: Can't close invoices using checkboxes from invoices.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38155 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Bug 38766 depends on bug 38765, which changed state. Bug 38765 Summary: Internal server error when merging invoices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38765 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38766 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix to restore expected behaviour. Confirmation message not documented specifically. Noting to add or edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org