[Bug 32055] New: Remove GetImportRecordMatches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Bug ID: 32055 Summary: Remove GetImportRecordMatches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 32054 removes most uses, we should finish the job -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31710 [Bug 31710] Replace GetImportRecordsRange with object methods -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 --- Comment #1 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170163&action=edit Bug 32055: Change code to use get_import_record_matches To test: 1. Apply patch, restart_all Bibliographic records: 2. Cataloging -> Stage records for import 3. Choose a file with bibliographic records 4. Choose a record matching rule -> Save 5. View batch and notice the table displays the information correctly Authority records: 6. Administration -> Record matching rules -> New record matching rule 7. Add a code, description, and Match Threshold: 1000 8. Match point 1: Search index: local-number Score: 1000 Tag: 001 9. Save 10. Cataloging -> Stage records for import 11. Choose a file with authority records 12. Change Record type to 'Authority' and choose the matching rule you made previously 13. View batch and notice the table displays the information correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 --- Comment #2 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 170164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170164&action=edit Bug 32055: Removed GetImportRecordMatches subroutine -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170164|0 |1 is obsolete| | --- Comment #3 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 176454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176454&action=edit Bug 32055: Removed GetImportRecordMatches subroutine Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170163|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 179938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179938&action=edit Bug 32055: Change code to use get_import_record_matches To test: 1. Apply patch, restart_all Bibliographic records: 2. Cataloging -> Stage records for import 3. Choose a file with bibliographic records 4. Choose a record matching rule -> Save 5. View batch and notice the table displays the information correctly Authority records: 6. Administration -> Record matching rules -> New record matching rule 7. Add a code, description, and Match Threshold: 1000 8. Match point 1: Search index: local-number Score: 1000 Tag: 001 9. Save 10. Cataloging -> Stage records for import 11. Choose a file with authority records 12. Change Record type to 'Authority' and choose the matching rule you made previously 13. View batch and notice the table displays the information correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176454|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 179939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179939&action=edit Bug 32055: Removed GetImportRecordMatches subroutine Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32055 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- [FAIL] tools/batch_records_ajax.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl tools/batch_records_ajax.pl` FAIL valid "GetImportRecordMathes" is not exported by the C4::ImportBatch module Can't continue after import errors -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org