[Bug 37126] New: Provide link to patron account when checking out to statistical patron ends checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Bug ID: 37126 Summary: Provide link to patron account when checking out to statistical patron ends checkout Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: catrina@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 167878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167878&action=edit CardNumber should be link to patron account Bug 27992 added the borrower name and card number if an item scanned for local use is checked out to another borrower and it clears it from that patron's checkins. Rather than just providing the patron name and card number, it would be helpful to hyperlink to the patron account so staff can easily access the borrower's information and make sure no overdue fines have been errantly applied to their account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 --- Comment #1 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168331&action=edit Bug 37126: Added link to patron account when checking out to statistical patron ends checkout To test: 1. Check out item with patron 2. Check out the same item locally with a separate patron 3. Notice how "Item checked in from: PATRON_NAME (BORROWERNUMBER) is not hyperlinked 4. Apply patch 5. Repeat steps 1 and 2 6. Notice how "Item checked in from: PATRON_NAME (BORROWERNUMBER) is now hyperlinked to the borrower's details -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 168336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168336&action=edit Bug 37126: Add link to patron account when checking out to statistical patron ends checkout When checking out an item to a statistical patron, where that item is already checked out to another patron, the patron details in the message do not link to that patron. This patch fixes this so that the patron details are now linked. This could be useful so that staff can more easily access the patron's details, and can, for example, check for any incorrect charges. Test plan: 1. Set up a statistical patron for local use:[1] 1.1 Add a statistical patron category (Administration > Patrons and circulation > Patron categories), for example: - Category code: STAT - Description: Statistical - Enrollment period: 99 - Category type: Statistical 1.2 Add a new statistical paton (Patrons > +New patron > Statistical), for example: - Surname: Reference Statistical Patron - Card number: refstat 2. Check out an item to a standard patron. 3. Check out the same item to the statistical patron created in step 1.2. 4. Note that when the item is checked out to the statistical patron, the patron name and number in the message are not linked: "Item checked in from: PATRON_NAME (BORROWERNUMBER)". 5. Apply the patch. 6. Repeat steps 2 and 3. 7. Note that the patron details in the message are now linked. [1] Monday Minutes: Statistical Patron and Local Use: https://bywatersolutions.com/education/monday-minutes-statistical-patron-and... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #168331|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Comment on attachment 168331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168331 Bug 37126: Added link to patron account when checking out to statistical patron ends checkout I have fixed that patch so that it now works as expected - I changed patron=BOrrOWER to patron=BORROWER. With the patch as it was, there was no patron name and card number displayed. I also amended the commit message to follow the commit message guidelines (https://wiki.koha-community.org/wiki/Commit_messages). For some reason, the patch as applied did not have the test plan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | Text to go in the| |This enhancement links the release notes| |patron details in the | |message displayed when | |checking out an item to a | |statistical patron, where | |that item is already | |checked out to another | |patron. Previously, the | |patron details in the | |message did not link to the | |patron. This now makes it | |easier for staff to check | |the patron's details, for | |example, to check for any | |incorrect charges. Version|22.11 |Main --- Comment #4 from David Nind <david@davidnind.com> --- I've added the assignee, and a release note. Feel free to amend these, and the patch commit message, as requried. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168336|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 168371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168371&action=edit Bug 37126: Add link to patron account when checking out to statistical patron ends checkout When checking out an item to a statistical patron, where that item is already checked out to another patron, the patron details in the message do not link to that patron. This patch fixes this so that the patron details are now linked. This could be useful so that staff can more easily access the patron's details, and can, for example, check for any incorrect charges. Test plan: 1. Set up a statistical patron for local use:[1] 1.1 Add a statistical patron category (Administration > Patrons and circulation > Patron categories), for example: - Category code: STAT - Description: Statistical - Enrollment period: 99 - Category type: Statistical 1.2 Add a new statistical paton (Patrons > +New patron > Statistical), for example: - Surname: Reference Statistical Patron - Card number: refstat 2. Check out an item to a standard patron. 3. Check out the same item to the statistical patron created in step 1.2. 4. Note that when the item is checked out to the statistical patron, the patron name and number in the message are not linked: "Item checked in from: PATRON_NAME (BORROWERNUMBER)". 5. Apply the patch. 6. Repeat steps 2 and 3. 7. Note that the patron details in the message are now linked. [1] Monday Minutes: Statistical Patron and Local Use: https://bywatersolutions.com/education/monday-minutes-statistical-patron-and... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Works, code looks good, and QA tool passes. Thanks all! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37126 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org