[Bug 38211] New: New biblio in non-Default framework opens in Default on first edit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Bug ID: 38211 Summary: New biblio in non-Default framework opens in Default on first edit Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, m.de.rooy@rijksmuseum.nl Depends on: 37947 Seems unlikely, but it does. Prior to the patch from bug 37947, there was the unnoticed bug 38168 - if you created a biblio in the framework SR and then edited it again, the Settings menu would say you were in the Audio Cassettes, CDs framework, but the fields and tags would say you were in Default (easy check in MARC21 is that 001 and 003 are hidden in frameworks other than Default, so if you see them in the editor you are in Default). With the patch from bug 37947, the first time you edit a newly-created record, the editor opens in Default and the Settings menu says it is in Default, then every time after that the editor opens in the correct framework and the Settings menu agrees. Steps to reproduce: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are visible, and the Settings menu has a checkmark by Default 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37947 [Bug 37947] Import from Z39.50 doesn't open the record in editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Actually, let's call that major. Since I was looking for it and looking for the once-only thing, I wasn't saving the record on the first opening of the editor, but in general it's not obvious that you've opened a record in a framework other than the one it should have, so you'll just save it, moving it from the framework it had into the Default framework, which can be a cause of dataloss depending on your frameworks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|NEW |CONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38076 [Bug 38076] Librarians with only fast add permission can no longer edit or create fast add records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 173019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173019&action=edit Bug 38211: frameworkcode must be set before read It's a stupid global variable, we MUST have this init line BEFORE we read it! Test plan: See the other bugs linked with this one, confirm the test plan for all of them still pass. Test plan for this specific bug report: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Severity|major |critical Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173019|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 173048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173048&action=edit Bug 38211: frameworkcode must be set before read It's a stupid global variable, we MUST have this init line BEFORE we read it! Test plan: See the other bugs linked with this one, confirm the test plan for all of them still pass. Test plan for this specific bug report: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173048|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 173053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173053&action=edit Bug 38211: frameworkcode must be set before read It's a stupid global variable, we MUST have this init line BEFORE we read it! Test plan: See the other bugs linked with this one, confirm the test plan for all of them still pass. Test plan for this specific bug report: 1. Cataloging - New record -> Audio Cassettes, CDs 2. Fill in the required fields and save 3. Switch to 'Normal', Edit - Edit record 4. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs 5. Click the browser Back button, then Edit - Edit record 6. Note that 001 and 003 are not visible, and the Settings menu has a checkmark by Audio Cassettes, CDs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Oof...this script and its globals. Thanks, Jonathan! Passing QA (also tidied inline) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |emily.lamancusa@montgomeryc |.com |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New biblio in non-Default |New biblio in non-default |framework opens in Default |framework opens in default |on first edit |on first edit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New biblio in non-default |New bibliographic record in |framework opens in default |non-default framework opens |on first edit |in default on first edit --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the quick work here, Jonathan, Brendan and Emily! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.05 released in| | Status|Pushed to main |Pushed to stable --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 37947 and 38076 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Bug 38211 depends on bug 38076, which changed state. Bug 38076 Summary: Librarians with only fast add permission can no longer edit or create fast add records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38076 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38211 Bug 38211 depends on bug 37947, which changed state. Bug 37947 Summary: Import from Z39.50 doesn't open the record in editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37947 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org