[Bug 40743] New: Unable to select the correct fund when paying invoices.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Bug ID: 40743 Summary: Unable to select the correct fund when paying invoices. Change sponsored?: --- Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tgoatley@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 186059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186059&action=edit Display of order edit We are an early adopter to 25.05.02 and we're unable to select the correct fund when paying invoices. This refers to paying paper invoices we receive since as this Baker &Taylor example. Previously, we were given the option to select the fund, and since we have two active funds now due to closing out the fiscal year, we are only able to see one of the active funds (unfortunately not the fund we need to pay this invoice). I checked acquisitions permissions, and Sandra has full ACQ permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186083&action=edit Bug 40743: Active funds not visible in Fund dropdown on order receive page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 186084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186084&action=edit Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|normal |critical --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Broken feature, setting 'critical' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186083|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 186190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186190&action=edit Bug 40743: Active funds not visible in Fund dropdown on order receive page Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186084|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 186191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186191&action=edit Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- What I noted when receiving (both before and after the patches), is that if you tick inactive, in the list of funds it shows in the dropdown list as: Current Keep current (Whatever the fund was that you selected) {budget_description} Inactive Inactive fund name Main budget Main fund ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unable to select the |Unable to select the |correct fund when paying |correct fund when paying |invoices. |invoices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- *** Bug 40804 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Caused by commit ce0ef254112e23ee7ad32225744b5a30d156d8d8 Bug 38714: acqui/orderreceive.tt Sorry about that! I do agree with the second patch, however I don't understand why we need the first one (change to .pl). Can you explain please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186402&action=edit Bug 40743: Fix description of inactive budget Without this patch it's always "{budget_description} (Inactive)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38714 Version|25.05 |unspecified Keywords| |rel_25_05_candidate --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- This last patch fixes a translation issue caused by the same commit. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714 [Bug 38714] Adjust templates for prettier -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
Caused by
commit ce0ef254112e23ee7ad32225744b5a30d156d8d8 Bug 38714: acqui/orderreceive.tt
Sorry about that!
I do agree with the second patch, however I don't understand why we need the first one (change to .pl). Can you explain please?
I dont see any reply about this question. CHanging status for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Holly Bowden <hbowden@weber.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbowden@weber.edu --- Comment #12 from Holly Bowden <hbowden@weber.edu> --- All active budgets not available when receiving in Acq module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- We've received some sponsorship to help revive this fix as it's affecting many of our libraries. I don't want to step on toes in case someone else is planning to come back to this - if you are, can you please let me know? Otherwise I'll pick this up in the coming days. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Aleisha Amohia from comment #13)
We've received some sponsorship to help revive this fix as it's affecting many of our libraries. I don't want to step on toes in case someone else is planning to come back to this - if you are, can you please let me know? Otherwise I'll pick this up in the coming days.
IMO all it needs is to remove the pl change: ie. obsolete the first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186190|0 |1 is obsolete| | Attachment #186191|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 188264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188264&action=edit Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186402|0 |1 is obsolete| | --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 188265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188265&action=edit Bug 40743: Fix description of inactive budget Without this patch it's always "{budget_description} (Inactive)" Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #14)
(In reply to Aleisha Amohia from comment #13)
We've received some sponsorship to help revive this fix as it's affecting many of our libraries. I don't want to step on toes in case someone else is planning to come back to this - if you are, can you please let me know? Otherwise I'll pick this up in the coming days.
IMO all it needs is to remove the pl change: ie. obsolete the first patch.
I tested the two patches and can confirm they solve the problem without the first patch. Setting to Signed Off with the .pl change obsolete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188264|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188309&action=edit Bug 40743: Make active funds visible again To test: 1. Create a basket and add an item to the order. Close the basket. 2. Receive shipment. Create an invoice. 3. Go to the invoice and then go to the receipt page. 4. Receive the item you had added to your basket. Under Fund you will only see “Keep current (your budget name)”. Active budgets are not visible. 5. Click on “Show inactive” — both inactive and active budgets become visible. 6. Apply the patch. Restart all. 7. Repeat step 3 and 4. Notice now that the active budgets are visible under your Fund dropdown. On this step you can create an inactive budget / fund if you don’t have one set already. Next click on “Show inactive” and notice that the active fund is active, and the inactive fund has a budget_description of inactive. 8. Test to make sure budgets stick. 9. Sign off and have a wonderful day! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188265|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188310&action=edit Bug 40743: Fix description of inactive budget Without this patch it's always "{budget_description} (Inactive)" Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #22 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 38714 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #23 from David Nind <david@davidnind.com> --- Bug fix, no change required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org