[Bug 25514] New: REST/Plugin/Objects.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Bug ID: 25514 Summary: REST/Plugin/Objects.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 24502 Master_U18 (#785) 13:53:07 koha_1 | # Premature connection close 13:53:07 koha_1 | 13:53:07 koha_1 | # Failed test 'GET /biblios' 13:53:07 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 270. 13:53:07 koha_1 | 13:53:07 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 13:53:07 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 270. 13:53:07 koha_1 | # got: undef 13:53:07 koha_1 | # expected: '1' 13:53:07 koha_1 | # Looks like you failed 2 tests of 4. 13:53:07 koha_1 | 13:53:07 koha_1 | # Failed test 'object.search helper with query parameter' 13:53:07 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 277. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502 [Bug 24502] Add a query language and param (q=) to the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24229 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Master_D9_MDB_Latest (#333) 18:28:12 koha_1 | # Premature connection close 18:28:12 koha_1 | 18:28:12 koha_1 | # Failed test 'GET /biblios' 18:28:12 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 310. 18:28:12 koha_1 | 18:28:12 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 18:28:12 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 310. 18:28:12 koha_1 | # got: undef 18:28:12 koha_1 | # expected: '1' 18:28:12 koha_1 | # Looks like you failed 2 tests of 4. 18:28:12 koha_1 | 18:28:12 koha_1 | # Failed test 'object.search helper with query parameter' 18:28:12 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 317. 18:28:30 koha_1 | # Premature connection close 18:28:30 koha_1 | 18:28:30 koha_1 | # Failed test 'GET /biblios?q={"suggestions.suggester.patron_id": "79"}' 18:28:30 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 333. 18:28:30 koha_1 | 18:28:30 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 18:28:30 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 333. 18:28:30 koha_1 | # got: undef 18:28:30 koha_1 | # expected: '1' 18:28:30 koha_1 | # Looks like you failed 2 tests of 4. 18:28:30 koha_1 | 18:28:30 koha_1 | # Failed test 'object.search helper with q parameter' 18:28:30 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 340. 18:28:49 koha_1 | # Premature connection close 18:28:49 koha_1 | 18:28:49 koha_1 | # Failed test 'GET /biblios' 18:28:49 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 356. 18:28:49 koha_1 | 18:28:49 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 18:28:49 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 356. 18:28:49 koha_1 | # got: undef 18:28:49 koha_1 | # expected: '1' 18:28:49 koha_1 | # Looks like you failed 2 tests of 4. 18:28:49 koha_1 | 18:28:49 koha_1 | # Failed test 'object.search helper with x-koha-query header' 18:28:49 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 363. 18:29:07 koha_1 | # Premature connection close 18:29:07 koha_1 | 18:29:07 koha_1 | # Failed test 'GET /biblios?q={"suggestions.suggester.firstname": "patron1"}' 18:29:07 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 379. 18:29:07 koha_1 | 18:29:07 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 18:29:07 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 379. 18:29:07 koha_1 | # got: undef 18:29:07 koha_1 | # expected: '1' 18:29:08 koha_1 | # Looks like you failed 2 tests of 6. 18:29:08 koha_1 | 18:29:08 koha_1 | # Failed test 'object.search helper with all query methods' 18:29:08 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 389. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Master_U18 #844 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is still valid Master_D9_My8 #459 14:30:42 koha_1 | # Premature connection close 14:30:42 koha_1 | 14:30:42 koha_1 | # Failed test 'GET /biblios' 14:30:42 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 322. 14:30:42 koha_1 | 14:30:42 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 14:30:42 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 322. 14:30:42 koha_1 | # got: undef 14:30:42 koha_1 | # expected: '1' 14:30:42 koha_1 | # Looks like you failed 2 tests of 4. 14:30:42 koha_1 | 14:30:42 koha_1 | # Failed test 'object.search helper with query parameter' 14:30:42 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 329. 14:30:57 koha_1 | # Premature connection close 14:30:57 koha_1 | 14:30:57 koha_1 | # Failed test 'GET /biblios?q={"suggestions.suggester.patron_id": "76"}' 14:30:57 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 345. 14:30:57 koha_1 | 14:30:57 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 14:30:57 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 345. 14:30:57 koha_1 | # got: undef 14:30:57 koha_1 | # expected: '1' 14:30:58 koha_1 | # Looks like you failed 2 tests of 4. 14:30:58 koha_1 | 14:30:58 koha_1 | # Failed test 'object.search helper with q parameter' 14:30:58 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 352. 14:31:27 koha_1 | # Premature connection close 14:31:27 koha_1 | 14:31:27 koha_1 | # Failed test 'GET /biblios?q={"suggestions.suggester.firstname": "patron1"}' 14:31:27 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 391. 14:31:27 koha_1 | 14:31:27 koha_1 | # Failed test 'there should be 1 biblio with suggestions of patron 1' 14:31:27 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 391. 14:31:27 koha_1 | # got: undef 14:31:27 koha_1 | # expected: '1' 14:31:28 koha_1 | # Looks like you failed 2 tests of 6. 14:31:28 koha_1 | 14:31:28 koha_1 | # Failed test 'object.search helper with all query methods' 14:31:28 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 401. 14:31:38 koha_1 | # Looks like you failed 3 tests of 10. 14:31:38 koha_1 | [13:31:38] t/db_dependent/Koha/REST/Plugin/Objects.t ............................... 14:31:38 koha_1 | Dubious, test returned 3 (wstat 768, 0x300) 14:31:38 koha_1 | Failed 3/10 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113342&action=edit Bug 25514: Try to fix random failure from REST/Plugin/Objects.t It's causing a "Premature connection close" error https://docs.mojolicious.org/Mojolicious/Guides/FAQ#What-does-Premature-conn... This is just a guess but maybe it would help to have the Test::Mojo object initiated just before the get? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target Assignee|chris@bigballofwax.co.nz |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #4)
Created attachment 113342 [details] [review] Bug 25514: Try to fix random failure from REST/Plugin/Objects.t
It's causing a "Premature connection close" error
https://docs.mojolicious.org/Mojolicious/Guides/FAQ#What-does-Premature- connection-close-mean
This is just a guess but maybe it would help to have the Test::Mojo object initiated just before the get?
It is not a 'timeout' per-se, usually. But some exception making the controller terminates before sending an answer to the caller. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Again on Koha_Master_D9_My8 #460 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It seem it's possible to reproduce locally by running in parallel `stress --hdd 1` it should fail after 5 min at most. Likely the first errors come first. t/db_dependent/Koha/REST/Plugin/Objects.t .. 3/10 # Premature connection close # Failed test 'GET /orders?order_id=1' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 269. # Failed test 'exact match for JSON Pointer "/0"' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 269. # Structures begin differing at: # $got = undef # $expected = HASH(0x558d657c4810) # Looks like you failed 2 tests of 2. t/db_dependent/Koha/REST/Plugin/Objects.t .. 4/10 # Failed test 'objects.search helper, embed' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 273. t/db_dependent/Koha/REST/Plugin/Objects.t .. 5/10 # Premature connection close # Failed test 'GET /biblios' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 322. # Failed test 'there should be 1 biblio with suggestions of patron 1' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 322. # got: undef # expected: '1' # Looks like you failed 2 tests of 4. t/db_dependent/Koha/REST/Plugin/Objects.t .. 6/10 # Failed test 'object.search helper with query parameter' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 329. t/db_dependent/Koha/REST/Plugin/Objects.t .. 7/10 # Premature connection close # Failed test 'GET /biblios' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 368. # Failed test 'there should be 1 biblio with suggestions of patron 1' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 368. # got: undef # expected: '1' # Looks like you failed 2 tests of 4. t/db_dependent/Koha/REST/Plugin/Objects.t .. 8/10 #### ETC more similar error #### -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same with the patch, Victor? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113342|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113539&action=edit Bug 25514: Try to fix random failure from REST/Plugin/Objects.t It's causing a "Premature connection close" error https://docs.mojolicious.org/Mojolicious/Guides/FAQ#What-does-Premature-conn... This is just a guess but maybe it would help to have the Test::Mojo object initiated just before the get? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I though it wasn't going to work but actually yes! :D Some inconsistencies like suddenly regardless of with or without the patch it wouldn't fail. One or two instances of failure with the patch. But nonetheless after numerous attempts: without the patch, it fails after a short amount of time. While with the patch, it doesn't fail even after waiting at least two or three times the previous amount of time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://jenkins.koha-community.org/job/Koha_Master_D9/1504/consoleFull -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org