http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Sorry Paola, I forgot to attach the DB changes patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #5) This works only on the neworderempty.pl script. So if you order from a suggestion, suscription, new record, existing record. It looks to work for all of these cases. I tried for a suggestion and if I change the value of the itemtype dropdown-list, the vat value is updated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Paola Rossi <paola.rossi@cineca.it> --- Hi, Jonathan. My results didn't match your observations in comment 6, so I've made some further tests. I've applied the patches. On ADMIN in "Item Types" I set "Tax rate" of Book to 5% On ADMIN I set the system pref gist to: 0.10|0|0.05|0.23 [As ADMIN says: "First is the default."] The vendor was configured 0-0, and his tax rate was set to 23%. [I kept the system pref "AcqCreateItem" to default value "placing an order".] The patches worked perfectly well in these 4 cases: A) ordering from an existing record: On a BK biblio record I _immediately_ saw 5% in the tax rate of the "Accounting details" in the "New order" page (RIGHT just as required, I think). And, on a biblio record with none itemtype, I _immediately_ saw 23% there (RIGHT, I also think) B) ordering from a subscription C) ordering from a staged file: the neworderempty.pl script is used by way of the link "Add order", at the right of the uploaded-and-staged-file's titles, in the tag "Select to import" under "Add orders from (name of my file)" D) ordering from titles with highest hold ratios. Ordering from a BK suggestion [or from an empty record] I've seen 23% in the tax rate of the order: it's the vendor' tax rate, instead of the expected tax rate 5% of the BK' itemtype (ERROR). Where have I been wrong, please? Did I forget anything? I beg your pardon, but I should pass the patch to "Failed QA" status for now. [Perhaps is there anything missing in the patches? there is nothing about neworderempty.pl, I see] I've a lot of doubts. Note that a suggestion has no corresponding biblio record in the DB until it has been ordered. So I ask myself how the neworderempty.pl script can find an "itemtype at the biblio level" ordering from a suggestion. [Anyway, I didn't find a way in koha to create a suggestion together with a biblio record: neither from ACQ nor from OPAC]. I'm in doubt: are we into the test for 12993 or not? Moreover, the order had shown the suggestion' price very well in "Accounting details"! If we're into the 12993 test, couldn't the suggestion's itemtype have been read by the same way? It's not a biblio level' itemtype, as you required, but it seems to me being no other way to have an itemtype for a BK suggestion. In case, I invite you to let me know the steps of your test on suggestion, please. ------------------------------------------------------------ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 32284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32284&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the 3 patches against master 3.17.00.027 . Now ordering "from suggestion" and ordering "from a new (empty) record" let me see and set the type of the document! Thanks, Julian. On ADMIN in "Item Types" I've set: "Tax rate" of Book to 5% "Tax rate" of Serial to 7% "Tax rate" has been kept "none" elsewhere. On ADMIN I set the syspref "gist" to: "0.10|0|0.05|0.07|0.23" [As ADMIN says: "First is the default."] I set the syspref "item-level_itypes" to "biblio record", as you've kindly indicated. The vendor was configured 0-0, and his tax rate was set to 23%. [I kept the syspref "AcqCreateItem" to default value "placing an order".] 1) I was ordering music from a suggestion [or a new empty record]. On the page of neworderempty.pl the item-type default has been set to Book. So the default value is set to 5%, as on ADMIN (RIGHT). So I changed the type to music, but the 5% has been kept (ERROR): it happened because the music's biblio level item-type was set to none on ADMIN. If I changed the type to serial, and then to music, the music's tax rate was another one, 7% (ERROR). In spite of 5% or 7%, the value I expected was 23%, the vendor's default tax rate, as if I ordered "from existing" music. 2) I ordered "from an external source", so using "neworderempty.pl". The shown tax rate was 23%, the vendor's default tax rate (RIGHT, I think). No item type's dropdown list was available here for the document. Perhaps could item type's dropdown list be added, like in the suggestion's case or in the empty record's case? For 1) I pass the patches to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32018|0 |1 is obsolete| | --- Comment #14 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 33306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33306&action=edit 32018: Bug 12993: Add a default tax rate on item types - DB changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note for later: Add bug number to datebase update message -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33306|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Tax rate: no default This is a confusing term. Would something like manual be better? Or a word that expresses that it is a different/deviating rate than those in the table (read: preference)? If you have item-level_itypes==biblio, the selection seems to work. If you have item-level_itypes==item, the situation is confusing. The first rate of the pref is selected (fine). But I save my first item, I would expect that it would update my tax rate (at least the first time). It does not. I understand that if you add another item of another type, you cannot make a choice. You could choose for defaulting to the rate of the first item. When I set AcqCreateItem <> ordering, the situation is still different. You have no items/item types. So no defaults. My conclusion is that adding this rate to the item type page in Administration promises much, but does not bring that much. Note that the item type page does not tell you that filling the tax rate is only useful when you item-level_itypes==biblio and AcqCreateItem == ordering. Perhaps you should tell that or only show them in that case? I am moving this report to FQA for this functional perspective. This still needs some attention imo before pushing it to master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35394&action=edit Bug 12993: (qa-follow-up) Display the column only when it is useful As mention by comment 19, the default tax rate defined for item types is only useful when the items are created on ordering and the item type is defined at the biblio level. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #23 from Marc Véron <veron@veron.ch> --- Sorry, did not apply: Applying: Bug 12993: Add a default tax rate on item types Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging admin/itemtypes.pl Applying: Bug 12993: Select automatically itemtype on neworderempty.pl Applying: Bug 12993: Add a default tax rate on item types - DB changes Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Failed to merge in the changes. Patch failed at 0001 Bug 12993: Add a default tax rate on item types - DB changes -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39567&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39569&action=edit Bug 12993: (qa-follow-up) Display the column only when it is useful As mention by comment 19, the default tax rate defined for item types is only useful when the items are created on ordering and the item type is defined at the biblio level. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |claire.hernandez@biblibre.c |ommunity.org |om -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Assignee|claire.hernandez@biblibre.c |alex.arnaud@biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39567|0 |1 is obsolete| | --- Comment #31 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45539&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39569|0 |1 is obsolete| | --- Comment #33 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45541&action=edit Bug 12993: (qa-follow-up) Display the column only when it is useful As mention by comment 19, the default tax rate defined for item types is only useful when the items are created on ordering and the item type is defined at the biblio level. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #35 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 45543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45543&action=edit Bug 12993: Add gstrate in itemtypes form and table -- You are receiving this mail because: You are watching all bug changes.