[Bug 15900] New: Remove use of recordpayment in ProcessOfflinePayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Bug ID: 15900 Summary: Remove use of recordpayment in ProcessOfflinePayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Blocks| |15899 Depends on| |15895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 [Bug 15899] Remove the use of recordpayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48337&action=edit Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment Test plan: 1) Apply this patch 2) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- On top of 15895, test fails prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 1/83 Can't locate object method "find" via package "Koha::Borrowers" (perhaps you forgot to load "Koha::Borrowers"?) at /home/bgkriegel/kohaclone/C4/Circulation.pm line 3912. Am I missing something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48337|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52142&action=edit Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment Test plan: 1) Apply this patch 2) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52142|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 54742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54742&action=edit Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment Test plan: 1) Apply this patch 2) prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #2)
On top of 15895, test fails
prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 1/83 Can't locate object method "find" via package "Koha::Borrowers" (perhaps you forgot to load "Koha::Borrowers"?) at /home/bgkriegel/kohaclone/C4/Circulation.pm line 3912.
Am I missing something?
Same here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55261&action=edit Bug 15900 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54742|0 |1 is obsolete| | Attachment #55261|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55872&action=edit Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment Test plan: 1) Apply this patch 2) prove t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55873&action=edit Bug 15900 [QA Followup] - Use Koha::Patrons instead of Koha::Borrowers Since the initial submission of this patch, the module Koha::Borrowers has been moved to Koha::Patrons. This patch changes the call from Koha::Borrowers to Koha::Patrons. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org