[Bug 19131] New: Script marc_subfields_structure ignores add/ edit when liblibrarian is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19131 Bug ID: 19131 Summary: Script marc_subfields_structure ignores add/edit when liblibrarian is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Around saving new or changed records in admin/marc_subfields_structure we have this construction: if (defined($liblibrarian) && $liblibrarian ne "") { my $is_demo = C4::Context->config('demo') || ''; if ( $is_demo ne '1' ) { So if you have no liblibrarian text or demo is set, your changes are lost. We could do better than that ! Note that the demo config variable is only used a couple of times in Koha in the context of changing biblio or auth fields and subfields. Do we need it ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19131 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should remove it - I doubt that the current implementation is still working correctly and in use. Should we create an omnibus? I found a note in Auth.pm: # DEMO => the demo user is allowed to do everything (if demo set to 1 in koha.conf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19131 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12227 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org