[Bug 28728] New: Holds ratio page links to itself pointlessly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Bug ID: 28728 Summary: Holds ratio page links to itself pointlessly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) - Go to the holds ratio page in circulation - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on This link as it exists now seems completely pointless. I propose we make it point to the holds tab for the bib in question instead (/cgi-bin/koha/reserve/request.pl?biblionumber=). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 123011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123011&action=edit Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Turns out that link was doing something -- clicking it changed the ratio value for your search to the ratio for the title in question. I really don't see the utility in that, so I removed it and replaced it with a link to the title's holds page. Please let me know if the old behavior needs to be retained, but I suspect it does not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123011|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123096&action=edit Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123096|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123103&action=edit Bug 28728: Link to holds page from holds raio To test: 1 - Find a bib with 1 item, place 3 bib-level holds on it (just to make sure there's at least one title on your holds ratio page) 2 - Go to the holds ratio page in circulation 3 - mouse over the Holds Ratio column, see that the number there is a link to http://[your koha]/cgi-bin/koha/circ/reserveratios.pl#, the page you're already on 4 - apply patch, restart_all, reload page 5 - link now goes to the holds page for that title Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #2)
Turns out that link was doing something -- clicking it changed the ratio value for your search to the ratio for the title in question. I really don't see the utility in that, so I removed it and replaced it with a link to the title's holds page. Please let me know if the old behavior needs to be retained, but I suspect it does not.
How do we know it's actually not used? Did you ask around you? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
How do we know it's actually not used? Did you ask around you?
I haven't asked around beyond showing this bug to a few people, but I've found no documentation or discussion of the behavior and, frankly, it doesn't really *do* much. I'd hate for this to stall out due to the difficulty of demonstrating that the current link isn't used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I think the updated behavior is much more user-friendly, not to mention actually useful. I think it's more relevant to the use of the report to be able to click directly to the holds list than it is to click to type a number. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
Pushed to master for 21.11, thanks to everybody involved!
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it has been pushed to 21.05.x for 21.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.03 |21.11.00,21.05.03,20.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- For what it's worth, the bit about clicking the ratio to populate the form field dates back to 2009 in commit de38cf6df from bug 3130. However, _why_ this was done is currently lost to the mists of time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28728 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29279 [Bug 29279] Holds ratio report not sorting correctly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org