[Bug 24296] New: Move stock rotation transfer triggers from `comments` to `trigger`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Bug ID: 24296 Summary: Move stock rotation transfer triggers from `comments` to `trigger` Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Stock rotation misused the 'comments' field in branchtransfers to track that a transfer was triggered by the stock rotation subsystem. We should use a the new 'trigger' field for this instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24287 Blocks| |23432 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 [Bug 24287] Transfers should record how they were triggered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97433&action=edit Bug 24296: Update stockrotation process to use branchtransfers.trigger This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'trigger' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. 3) Navigate to the transferstosend page in the circulation area of the staff client.. no errors should be encountered. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97434&action=edit Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298 [Bug 24298] Record if a transfer was triggered by 'return to homebranch' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|4234 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97434|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97504&action=edit Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. https://bugs.koha-community.org/show_bug.cgi?id=24292 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97433|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97505&action=edit Bug 24296: Update stockrotation process to use branchtransfers.trigger This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'trigger' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. https://bugs.koha-community.org/show_bug.cgi?id=24292 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97504|0 |1 is obsolete| | Attachment #97505|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97517&action=edit Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. https://bugs.koha-community.org/show_bug.cgi?id=24292 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97518&action=edit Bug 24296: Update stockrotation process to use branchtransfers.trigger This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'trigger' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. https://bugs.koha-community.org/show_bug.cgi?id=24292 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97517|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97533&action=edit Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97534&action=edit Bug 24296: Update stockrotation process to use branchtransfers.reason This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'reason' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in t/db_dependent/StockRotationItems.t CONFLICT (content): Merge conflict in Koha/StockRotationItem.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9)
CONFLICT (content): Merge conflict in t/db_dependent/StockRotationItems.t CONFLICT (content): Merge conflict in Koha/StockRotationItem.pm
Forget that, a previous patch was not obsoleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97533|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98024&action=edit Bug 24296: Update existing data in the database This DB udpate adds the stockration states to the trigger enum in the branchtransfers table and then populates it with any such data currently contained within the comments field. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97534|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98025&action=edit Bug 24296: Update stockrotation process to use branchtransfers.reason This patch updates all occurences of stockrotation related lookups of branchtransfers status from using the 'comments' field to using the new 'reason' field. Test plan: 1) Work through the process of creating a stock rotation plan and adding items to the plan.. no errors should be encoutered during this process. 2) Run the stockrotation cronjob to move some items on.. no errors should be encountered. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move stock rotation |Move stock rotation |transfer triggers from |transfer triggers from |`comments` to `trigger` |`comments` to `reason` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Bug 24296 depends on bug 24287, which changed state. Bug 24287 Summary: Transfers should record how they were triggered. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #14 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org