[Bug 8000] New: Test mode for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Priority: P5 - low Change sponsored?: --- Bug ID: 8000 Assignee: henridamien@koha-fr.org Summary: Test mode for notices QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: wizzyrea@gmail.com Hardware: All Status: NEW Version: unspecified Component: Notices Product: Koha Koha should have a test mode for notices so a library can see what all of the notices will look like before go live, or to troubleshoot difficulties. Test mode would do the following: -redirect all mails to a specified (by default the defined library email address) address - Ability to specify a patron as a "test" patron -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 7999 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien@koha-fr.org |koha-bugs@lists.koha-commun | |ity.org QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |eric.begin@inLibro.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |eric.begin@inLibro.com |ity.org | --- Comment #2 from Eric Bégin <eric.begin@inLibro.com> --- We do have a simple feature allowing part of this. We added a SendAllEmailsToLibrarian. We will change this for allowing to SendAllEmailTo in order to specify any email address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|eric.begin@inLibro.com |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Created attachment 21976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21976&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. I'm not comfortable enough to specify the best way to generate emails, I personnally had to hack it in my environment. Feedbacks welcomed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Éric, it is a great idea! But I think your patch should replace *all* locations where a mail is sent in order to avoid nasty surprise. Indeed, sendmail is used at some places into Koha (use git grep sendmail). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #5 from Blou <philippe.blouin@inlibro.com> --- Created attachment 22315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22315&action=edit Bug 8000 - Override emails of every message sent from Koha Following Jonathan Druart's comments, I fixed every single sendmail occurence: C4/Letters.pm (fixed SendAlerts() in addition to the previous standard method) basket/sendbasket.pl misc/cronjobs/runreport.pl opac/opac-sendbasket.pl opac/opac-sendshelf.pl virtualshelves/sendshelf.pl Rebased on latest master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Blou <philippe.blouin@inlibro.com> --- Both patches are required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- + if (!($sendAllEmailsTo && $sendAllEmailsTo =~ /@/) ){ # some validation. This could be improved. Why not use Email::Valid->address() ? (This would be a new dependency.) I suggested to use this cpan module under report 9032 (failed qa for now).
From there we could go further in checking email addresses in Koha in a consistent way.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #8 from Blou <philippe.blouin@inlibro.com> --- I'd go one step further: All emailing should go through one and only one Koha method. It's good practice to have system calls isolated so that when upgrade or a new platform require adjustment, we don't need to run around touching 10 files. Or when we simply want to improve the process with validation... I'd be happy to do that... on a different bug :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Depends on| |11140 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Blou from comment #8)
I'd go one step further: All emailing should go through one and only one Koha method. It's good practice to have system calls isolated so that when upgrade or a new platform require adjustment, we don't need to run around touching 10 files. Or when we simply want to improve the process with validation...
I'd be happy to do that... on a different bug :)
I completely agree, to the point that I think we whould *require* the centralization of this code, and this patch depend on said centralization. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- I have a concern: we can't know if the user has been notified or if the email used was the SendAllEmailsTo content. It could cause problem on debugging if the pref is available on a production server. I don't have a suggestion (except adding a new column in the message_queue table (which is quite ugly). I am not sure it is blocker. -- You are receiving this mail because: You are watching all bug changes.
I have a concern: we can't know if the user has been notified or if the email used was the SendAllEmailsTo content. On most situation where Koha sends an email to ... anyone, we have no way to know such action is taking place (script, cron...). But if the email specified in the pref starts receiving a lot of emails, that should make it clear. I rather have lot of emails in that box that I then need to reforward, rather
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #11 from Blou <philippe.blouin@inlibro.com> --- than the reverse (call back emails sent wrongly to user).
It could cause problem on debugging if the pref is available on a production server. Actually, we need it on a production server. (Our) usage is to set as initial email when things are being set up. We do not want emails start flying to users while still getting set up.
Another common usage is for testing, but on a copy a production database. Obviously, we do not want users to receive email based on now out of date/sync data. This can act as a safety valve on various situation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21976|0 |1 is obsolete| | Attachment #22315|0 |1 is obsolete| | --- Comment #12 from Blou <philippe.blouin@inlibro.com> --- Created attachment 24784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24784&action=edit Bug 8000 - Override emails of every message sent from Koha Note: rebased to 3.15 For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. I'm not comfortable enough to specify the best way to generate emails, I personnally had to hack it in my environment. Feedbacks welcomed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Francois Charbonnier <francharb@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francharb@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22315|1 |0 is obsolete| | CC| |mtompset@hotmail.com --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 22315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22315 Bug 8000 - Override emails of every message sent from Koha Changes are in here that somehow got lost. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22315|0 |1 is obsolete| | Attachment #24784|0 |1 is obsolete| | --- Comment #14 from Blou <philippe.blouin@inlibro.com> --- Created attachment 25917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25917&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25919&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25920&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- I'm working on an improvement to this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25923&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25917|0 |1 is obsolete| | --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25924&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25919|0 |1 is obsolete| | --- Comment #20 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25925&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25920|0 |1 is obsolete| | --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25926&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25923|0 |1 is obsolete| | --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25927&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25927|0 |1 is obsolete| | --- Comment #23 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25928&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #10)
I have a concern: we can't know if the user has been notified or if the email used was the SendAllEmailsTo content. It could cause problem on debugging if the pref is available on a production server. I don't have a suggestion (except adding a new column in the message_queue table (which is quite ugly).
This is why I generated the last two patches. I added some not quite perfect testing for the first patch too. However, the testing becomes nicer when all four patches are applied. I did not add in the Email validation library as Marcel suggested in comment #7. I did not centralize anything. I don't know if Kyle was intending to imply that not centralizing it would mean this patch wouldn't make it past QA in comment #9. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- I forgot to mention: prove -v t/db_dependent/Letters.t This should effectively test all the changes in C4::Letters. Testing of: - basket/sendbasket.pl - misc/cronjobs/runreport.pl - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - virtualshelves/sendshelf.pl - C4::Letters::SendAlerts will require arcane librarian/koha knowledge. ;) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25939&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- I think it would either be best to either use Data::Validate::Email to validate the email address or just remove the simple email validation altogether. Since this validation isn't exactly valid it seems like a bit of a step backwards. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25924|0 |1 is obsolete| | --- Comment #28 from Blou <philippe.blouin@inlibro.com> --- Created attachment 25950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25950&action=edit Bug 8000 - Override emails of every message sent from Koha This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #29 from Blou <philippe.blouin@inlibro.com> --- Created attachment 25951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25951&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25924|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #30 from Blou <philippe.blouin@inlibro.com> --- in adding the new patch to validate the emails, I kept the same "patch name" and it overrode the previous one with the same name. So I 1) canceled the new "Override emails.,.." patch 2) submitted again the new one (under new name) 3) un-obsoleted the main one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #31 from M. Tompsett <mtompset@hotmail.com> --- It would seem that Kyle recommended Data::Validate::Email in comment 27 and Marcel recommended Email::Valid in comment 7. Email::Valid is far more active than Data::Validate::Email. Just thought I'd point out the activity. Is there a preference? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. Tompsett from comment #31)
It would seem that Kyle recommended Data::Validate::Email in comment 27 and Marcel recommended Email::Valid in comment 7. Email::Valid is far more active than Data::Validate::Email. Just thought I'd point out the activity. Is there a preference?
I agree with the activity. Moreover Data::Validate::Email depends on Data::Validate::Domain whereas Email::Valid does not depend on new dependencies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26446&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- No signoffers interested? This patch could be very useful for developers and pre-production installations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #35 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #34)
No signoffers interested?
This patch could be very useful for developers and pre-production installations.
Could you post a full and complete test plan, so we don't have to read through the comments? This has been off my radar for while, sorry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 koha@akafred.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@akafred.com --- Comment #36 from koha@akafred.com --- Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha Details: $ git show-ref -s HEAD 66c9e7a183e8e56c29b34e57d6c3c0b3cee09699 $ git bz apply 11140 No patches on bug 11140 $ git bz apply 8000 Bug 8000 - Test mode for notices 25924 - Bug 8000 - Override emails of every message sent from Koha 25925 - Bug 8000 - Missing test to trigger code change 25926 - Bug 8000 - Add a sentto_address column to message_queue 25928 - Bug 8000 - Correct inability to know where message was sent 25939 - Bug 8000 [QA Followup] - Change mis-used qw to q 25951 - Bug 8000 - Validate allEmailsTo email address before using it 26446 - Bug 8000: Replace Data::Validate::Email with Email::Valid Applying: Bug 8000 - Override emails of every message sent from Koha Auto-merging virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl Auto-merging misc/cronjobs/runreport.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging basket/sendbasket.pl Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm Failed to merge in the changes. Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25924|0 |1 is obsolete| | --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37463&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25925|0 |1 is obsolete| | --- Comment #38 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37464&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25926|0 |1 is obsolete| | --- Comment #39 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37465&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25928|0 |1 is obsolete| | --- Comment #40 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37466&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25939|0 |1 is obsolete| | --- Comment #41 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37467&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25951|0 |1 is obsolete| | --- Comment #42 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37468&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26446|0 |1 is obsolete| | --- Comment #43 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37469&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37463|0 |1 is obsolete| | --- Comment #44 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37472&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37464|0 |1 is obsolete| | --- Comment #45 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37473&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37465|0 |1 is obsolete| | --- Comment #46 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37474&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37466|0 |1 is obsolete| | --- Comment #47 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37475&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37467|0 |1 is obsolete| | --- Comment #48 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37476&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37468|0 |1 is obsolete| | --- Comment #49 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37477&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37469|0 |1 is obsolete| | --- Comment #50 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37478&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37472|0 |1 is obsolete| | --- Comment #51 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37481&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37473|0 |1 is obsolete| | --- Comment #52 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37482&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37474|0 |1 is obsolete| | --- Comment #53 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37483&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37475|0 |1 is obsolete| | --- Comment #54 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37484&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37476|0 |1 is obsolete| | --- Comment #55 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37485&action=edit Bug 8000 [QA Followup] - Change mis-used qw to q -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37477|0 |1 is obsolete| | --- Comment #56 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37486&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37478|0 |1 is obsolete| | --- Comment #57 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37487&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #58 from M. Tompsett <mtompset@hotmail.com> --- The FailedQA is more likely to get someone to fix this. I believe I have corrected the existing patches to apply to master. The issue now is that the email validations done in the very first patch were not updated when the validation of emails was added. They still have the =~ /@/ type code in them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|philippe.blouin@inlibro.com |maxime.beaulieu@inlibro.com CC| |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37481|0 |1 is obsolete| | --- Comment #59 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39985&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37482|0 |1 is obsolete| | --- Comment #60 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39986&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37483|0 |1 is obsolete| | --- Comment #61 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39987&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37484|0 |1 is obsolete| | --- Comment #62 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39988&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37486|0 |1 is obsolete| | --- Comment #63 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39989&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37487|0 |1 is obsolete| | --- Comment #64 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39990&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #65 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39991&action=edit Bug 8000 - Updated the remaining email validation to Email::Valid . Replaced the "=~ /@/" validation with Email::Valid->address(); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37485|0 |1 is obsolete| | --- Comment #66 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 39992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39992&action=edit Bug 8000 - Atomic Update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #67 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- M. Tompsett's patches would not apply. I rebased everything again. Hopefully this will the last time we need to do this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |indradg@gmail.com --- Comment #68 from Indranil Das Gupta <indradg@gmail.com> --- Hi Maxime, On Koha 3.21.00.008: CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39985|0 |1 is obsolete| | --- Comment #69 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40215&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39986|0 |1 is obsolete| | --- Comment #70 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40216&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39987|0 |1 is obsolete| | --- Comment #71 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40217&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39988|0 |1 is obsolete| | --- Comment #72 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40218&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39989|0 |1 is obsolete| | --- Comment #73 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40219&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39990|0 |1 is obsolete| | --- Comment #74 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40220&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39991|0 |1 is obsolete| | --- Comment #75 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40221&action=edit Bug 8000 - Updated the remaining email validation to Email::Valid . Replaced the "=~ @" validation with Email::Valid->address(); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39992|0 |1 is obsolete| | --- Comment #76 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40222&action=edit Bug 8000 - Atomic Update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #77 from M. Tompsett <mtompset@hotmail.com> --- Oops... found a mistake in my rebase... Let's try again. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40215|0 |1 is obsolete| | --- Comment #78 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40223&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40216|0 |1 is obsolete| | --- Comment #79 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40224&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40217|0 |1 is obsolete| | --- Comment #80 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40225&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40218|0 |1 is obsolete| | --- Comment #81 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40226&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40219|0 |1 is obsolete| | --- Comment #82 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40227&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40220|0 |1 is obsolete| | --- Comment #83 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40228&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40221|0 |1 is obsolete| | --- Comment #84 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40229&action=edit Bug 8000 - Updated the remaining email validation to Email::Valid . Replaced the "=~ @" validation with Email::Valid->address(); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40222|0 |1 is obsolete| | --- Comment #85 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40230&action=edit Bug 8000 - Atomic Update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #86 from M. Tompsett <mtompset@hotmail.com> --- All those changes in Letters.t and the line removals in those two conflicting areas: ARG! :) Anyways... Should be good to go again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #87 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to M. Tompsett from comment #86)
All those changes in Letters.t and the line removals in those two conflicting areas: ARG! :) Anyways... Should be good to go again.
yes. all commits in the set apply cleanly now. thank you mark tompsett. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |aleishaamohia@hotmail.com --- Comment #88 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Applying: Bug 8000 - Override emails of every message sent from Koha fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8000 - Override emails of every message sent from Koha Setting to Patch Doesn't Apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40223|0 |1 is obsolete| | Attachment #40224|0 |1 is obsolete| | Attachment #40225|0 |1 is obsolete| | Attachment #40226|0 |1 is obsolete| | Attachment #40227|0 |1 is obsolete| | Attachment #40228|0 |1 is obsolete| | Attachment #40229|0 |1 is obsolete| | Attachment #40230|0 |1 is obsolete| | --- Comment #89 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46354&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46354|0 |1 is obsolete| | --- Comment #90 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46355&action=edit Bug 8000 - Override emails of every message sent from Koha For testing purposes, we do not want emails sent to (legitimate) users. And sometime we also like to actually see what would be generated for the users. This preference will allow to override every message sent by koha with a new (temporary) To address. Leave it empty for normal usage. C4/Letters.pm installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref TESTING: 0) Run updatedatabase.pl 1) Enter a valid address for new preference SendAllEmailsTo, something that will be easily identified as NOT the normal destination for the Koha emails. 2) Have koha generate an email to a user. Or any other mean prefered that cause Koha to send email. 3) Validate that the email is NOT sent to the user. 4) Validate that the email IS sent to the overriding address. 5) Clean the preference 6) Redo the test, validate that the email is going to the right address. PS Not sure if those steps are precise enough. Here's one way: a) set AutoEmailOpacUser to true b) create a new user, with an email address c) Normally, a confirmation email is sent to the user. Validate that it goes to the SendAllEmailsTo one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #91 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46356&action=edit Bug 8000 - Missing test to trigger code change This adds a test case which will trigger _send_message_by_email and thus provide a way to run the changes made. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #92 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46357&action=edit Bug 8000 - Add a sentto_address column to message_queue The problem with message_queue is the inability to tell if the to_address was overriden at the time it was sent/attempted. This column will reflect what was attempted. MessageQueue.pm was generated by running the script installer/data/mysql/updatedatabase.pl and then git add'ing the resulting Koha/Schema/Result/MessageQueue.pm file. This was generated by running ./misc/devel/update_dbix_class_files.pl using appropriate -db_name=... -db_user=... -db_passwd=... parameters. This file is necessary for 3.16 and higher. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #93 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46358&action=edit Bug 8000 - Correct inability to know where message was sent The added column in the previous patch is used to determine where the message was actually sent when using email. This include a modification to the C4/Letters.pm libraries to appropriate track and update the column and revising the test file to check that the system preference actually does override or not the destination. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #94 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46359&action=edit Bug 8000 - Validate allEmailsTo email address before using it This patch adds Data::Validate::Email to validate the "allEmailsTo" address before using it as a unique destination. Added to PerlDependencies.pm for this and future potential usages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #95 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46360&action=edit Bug 8000: Replace Data::Validate::Email with Email::Valid -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #96 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46361&action=edit Bug 8000 - Updated the remaining email validation to Email::Valid . Replaced the "=~ @" validation with Email::Valid->address(); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #97 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Created attachment 46362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46362&action=edit Bug 8000 - Atomic Update -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |remi.mayrand-provencher@inL | |ibro.com --- Comment #98 from Rémi Mayrand-Provencher <remi.mayrand-provencher@inLibro.com> --- Every patch should now apply correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org