https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30666 [Bug 30666] Holds reminder cronjob (holds_reminder.pl) uses DataTime::subtract wrong -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 134504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134504&action=edit Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters, but should be using find_effective_template instead. Now, if a branch specific template does not exist, it will skip that branch. Test Plan: 1) Ensure you only have the default HOLD_REMINDER template 2) Become the koha user using koha-shell 3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v 4) Note that the script skips every branch 5) Apply this patch 6) Run the command in step 3 again 7) Note the script doesn't skip over any branches -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134504|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 134564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134564&action=edit Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters, but should be using find_effective_template instead. Now, if a branch specific template does not exist, it will skip that branch. Test Plan: 1) Ensure you only have the default HOLD_REMINDER template 2) Become the koha user using koha-shell 3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v 4) Note that the script skips every branch 5) Apply this patch 6) Run the command in step 3 again 7) Note the script doesn't skip over any branches Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134564|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134958&action=edit Bug 30667: Holds reminder cronjob (holds_reminder.pl) never uses default letter template Bug 28514 changed the way holds_reminder.pl searches for templates, using a direct search for letters, but should be using find_effective_template instead. Now, if a branch specific template does not exist, it will skip that branch. Test Plan: 1) Ensure you only have the default HOLD_REMINDER template 2) Become the koha user using koha-shell 3) Run misc/cronjobs/holds/holds_reminder.pl --days 7 -v 4) Note that the script skips every branch 5) Apply this patch 6) Run the command in step 3 again 7) Note the script doesn't skip over any branches Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master CC| |arthur.suzuki@biblibre.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to evelyn from comment #6)

Could this be backported to 21.11?

I've added the RMaint to CC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30667 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00, 21.11.11 released in| | --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.