http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8614&action=edit Bug 7757 - Edit basket vendor after it has been created -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8614|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8614|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 8615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8615&action=edit [SIGNED-OFF] Bug 7757 - Edit basket vendor after it has been created Signed-off-by: mveron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Template [% IF %] are not permissible inside HTML tags, as they can break translations. xt/tt_valid.t fails. Marking Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9391|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9422&action=edit Bug 7757 - Followup - Move IF outside of html tag -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9422|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9424&action=edit Bug 7757 - Followup - Move IF outside of html tag Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: there's something strange when I apply the 2nd patch : I get: [% FOREACH b IN booksellers %] llers %] [% IF booksellerid == b.id %] b.id %] <option value="[% b.id %]" selected="selected">[% b.name %]</option> /option> [% ELSE %] ELSE %] <option value="[% b.id %]">[% b.name %]</option> /option> (yes, truncated code) does others have the same problem ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #11)

Created attachment 9588 [details] Bug 7757 - Followup - Move IF outside of html tag

Paul, try with it (I removed tabulation characters)

Not better I've rewritten the patch QA comment: * patch #2 = tiny patch, necessary, passed QA * patch #1 = * improve some code, like -my $booksellerid; -$booksellerid = $input->param('booksellerid'); +my $booksellerid = $input->param('booksellerid'); * coding guidelines OK * I'm not sure - ModBasketHeader($input->param('basketno'),$input->param('basketname'),$input->param('basketnote'),$input->param('basketbooksellernote'),$input->param('basketcontractnumber')); + ModBasketHeader( $input->param('basketno'), $input->param('basketname'), $input->param('basketnote'), $input->param('basketbooksellernote'), $input->param('basketcontractnumber') || undef, $input->param('basketbooksellerid') ); is the best way to deal with an empty basketcontractnumber ( $input->param('basketcontractnumber') || undef ), but there's nothing about that in the coding guidelines, so I won't object passed QA About parameters: I think we should define a rule for new subs, about how we pass parameters. I think passing hashes would gracefully solve this kind of problem. So what about a rule like = identifier/mandatory fields are passed directly, others are passed through a hash The ModBasketHeader would then become: ModBasketHeader($basketno, { basketname => $basketname, basketnote => $basketnote, basketbooksellernote => $basketbooksellernote, basketcontractnumber => basketcontractnumber, basketbooksellerid=> $basketbooksellerid} ); Kyle, if you agree/like this idea, I can start a discussion on koha-devel ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 --- Comment #13 from Kyle M Hall <kyle.m.hall@gmail.com> ---

About parameters: I think we should define a rule for new subs, about how we pass parameters. I think passing hashes would gracefully solve this kind of problem. So what about a rule like = identifier/mandatory fields are passed directly, others are passed through a hash The ModBasketHeader would then become: ModBasketHeader($basketno, { basketname => $basketname, basketnote => $basketnote, basketbooksellernote => $basketbooksellernote, basketcontractnumber => basketcontractnumber, basketbooksellerid=> $basketbooksellerid} );

Kyle, if you agree/like this idea, I can start a discussion on koha-devel !

Paul, I am 110% behind this idea. I've been using hashes for parameter passing in most of my new code. I think it makes it much easier to extend subroutines after the fact. Right new we have subs that look like sub( $param1, $parm2, undef, $param3, 1, $param4 ) and this would make our code far better. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 --- Comment #15 from Kyle M Hall <kyle.m.hall@gmail.com> --- This is especially better when a sub requires one of multiple options ( we have a number of subroutines that require either $param1 OR $param2, but not necessarily both ). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8247 -- You are receiving this mail because: You are watching all bug changes.