[Bug 4850] New: CheckReserves does not respect holds circulation policies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Summary: CheckReserves does not respect holds circulation policies Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Hold requests AssignedTo: kyle.m.hall@gmail.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Scenario: A title has two items, one of an item type that allows holds, one of a type that does not. The rules defining this are entered into smart-rules.pl, and stored in the branch_item_rules, default_branch_item_rules and default_branch_circ_rules tables in the database. Patron A checks out the item that does not allow holds (Item A). Patron B then places a title-level (next available) hold on that title. Patron B must wait until Item B is available for their hold to be filled, as per our policy. When Patron A looks at their account in the OPAC, they'll see that Item A is on hold, and cannot be renewed. Similarly, when a staff member views their record in the staff client, they will see the item as unrenewal for the same reason (pending hold). When Patron A returns Item A, a message will come up to the staff member checking in that there is a hold on this item for Patron B. This is incorrect, since Item A cannot be held, and Patron B must continue to wait until Item B is available to have their hold filled. The three tables defined above (branch_item_rules, default_branch_item_rules and default_branch_circ_rules) are not consulted anywhere in the codebase except for GetBranchItemRule in C4/Circulation.pm, which in turn is only consulted in opac-reserve.pl and reserve/request.pl. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |ian.walls@bywatersolutions. | |com --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> --- Created attachment 2218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2218 Patch for Bug 4850 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |nengard@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P3 --- Comment #2 from Ian Walls <ian.walls@bywatersolutions.com> --- Previous patch insufficient. Requires more testing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-13 13:41:00 UTC --- Marking Failed QA per Ian's last comment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Is this still an issue? I think this may have been fixed by other work on the holds system, but I'm not entirely clear on what the problem is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- Still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #6 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I confirm that it's still an issue on master. If your item-level_itypes syspref is on item level, you can choose different itemtypes for the same biblio : some of them can be hold and the other not. If you choose to deal holds at a biblio level, you can encounter the problem described by Ian Walls : If there a hold on a biblio with 2 items that are checked out, if the first one to be checked in is not an item type that can be reserve, the circulation rules are not verified and the hold is placed on this item. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4850 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- In fact, it's just a problem of settings. Filling the "Defining circulation and fine rules for all libraries" table by setting 0 in "Holds allowed" column isn't sufficient. You have to fill the "Default holds policy by item type" table (default_branch_item_rules or branch_item_rules) and then, circulation rules are respected at a itemtype level for holds. So for me, this isn't an issue anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org