[Bug 32773] New: Have the ability to have more than 1 Fast Add framework

older
[Bug 40933] New: Add sms support...

bugzilla-daemon＠bugs.koha-community.org

1 Feb 2023 1 Feb '23

12:03 a.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Bug ID: 32773 Summary: Have the ability to have more than 1 Fast Add framework Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: george@nekls.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Currently the only fast add framework is the FA framework. I'd like the ability to create new/additional frameworks and designate them as fast add frameworks too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

22 Sep 22 Sep

10:47 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:50 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net --- Comment #1 from Miranda Nero <mnero@oslri.net> --- We would also like this. We have the majority of our libraries use the FA framework when creating new records, so it would be great to have the option to pre-fill fields based on format with different FA frameworks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Jun 7 Jun

10:28 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org --- Comment #2 from Angela Berrett <angela.berrett@familysearch.org> --- We would also like to see this - we have several projects being done by vendors or non-cataloger groups and each needs specific fields in a FA framework. We don't want to give any of them full cataloging rights. Having a specific framework for each project would be extremely helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Jul 25 Jul

7:26 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Oct 24 Oct

7:24 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Lauren Denny <lauren_denny@sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny@sil.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:24 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:31 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- We would like this. We use it for ILL workflow, so having more than one framework would really help in this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

7:47 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Nancy M. <nmumford@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmumford@clamsnet.org --- Comment #4 from Nancy M. <nmumford@clamsnet.org> --- CLAMS really needs this option too. We need the ability for our libraries to be able to maintain their Library of Things records without asking central cataloging to add and delete bib information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

25 Oct 25 Oct

8:42 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 173401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173401&action=edit Bug 32773: Add AllowAsFastAddFrameworks system preference This patch adds a new multiselect system preference that allows making selections from a list of biblioframeworks To test: 1. Apply patch 2. Update database perl installer/data/mysql/updatedatabase.pl 3. Search System preferences for 'AllowAsFastAddFrameworks' 4. See the dropdown list is populated from bibliographic frameworks 5. Go to Administration > MARC Bibliographic frameworks add a new framework 6. Confirm the new option is available in 'AllowAsFastAddFramework' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:48 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Posting work in progress for feedback. My idea is that admins could select specific bibliographic frameworks in the AllowAsFastAddFramework preference and then we could make those forms available to users who only have the fast_cataloging permission. They would be able to use the same dropdown to change the framework, but instead of really changing the framework it would just change the form they use. Then when the record is added it would still be saved with the FA code to indicate that it was added via fast cataloging. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Oct 26 Oct

3:30 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

30 Oct 30 Oct

4:04 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Eileen Chandler <echandler@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

31 Oct 31 Oct

2:45 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- I did a quick test, things look good so far! Some notes: 1. Bibliographic framework code: currently this is only 4 characters long. I think it may need to be longer to make the codes more meaningful, depending on how libraries want to name their fast add frameworks, for example FA-DVD, FA-BOOK, FA-JOURNAL, wouldn't work. But maybe not an issue, as when selecting frameworks in the record editor it displays and sorts by the framework description. 2. Selecting the fast add framework to use: I'm assuming the staff member would select from the current 'Settings' menu option when adding a record. Some ideas: - Maybe having another menu with 'Select fast add framework' could be an option. - Alternatively, when there is more than one fast add framework the staff member gets a dialog box to select the fast add framework before the add record form - Related to this, maybe have some way to select a default framework. 3. Permissions: assuming here that there is still some work to be done for this to work. 4. Database update: default for the new preference - it is set to NULL. Once permissions are done, for existing installations would they have to set this manually? Otherwise this would break how Koha knows what the fast add framework is - is it hard coded as FA?. Not sure how this works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1 Nov 1 Nov

7:23 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #14 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 173883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173883&action=edit Bug 32773: perltidy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

7:25 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

7:40 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #15 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing David! Also big thanks to Nick for chatting about this, which helped me to realize adding a column is a better way to achieve this. (In reply to David Nind from comment #8)

...

I did a quick test, things look good so far!

Some notes:

1. Bibliographic framework code: currently this is only 4 characters long. I think it may need to be longer to make the codes more meaningful, depending on how libraries want to name their fast add frameworks

Good point. I didn't include this because I'm new to making database changes and wanted to keep it simple

...

2. Selecting the fast add framework to use: I'm assuming the staff member would select from the current 'Settings' menu option when adding a record. Some ideas: - Maybe having another menu with 'Select fast add framework' could be an option.

You read my mind and this is included. This is exactly how I thought it would be best for the UI.

...

- Alternatively, when there is more than one fast add framework the staff member gets a dialog box to select the fast add framework before the add record form I think this is a good idea to enhance this further, for now it defaults to the default Fast Add and users can switch framework in the settings drop down.

...

- Related to this, maybe have some way to select a default framework. I'm not sure, but maybe this would be best implemented as a system preference where you can select a single framework

...

3. Permissions: assuming here that there is still some work to be done for this to work. This makes a couple changes to conditionals that set or check permissions so it's a good thing to keep an eye on when testing.

...

4. Database update: default for the new [column] Only the 'FA' framework sets is_fast_add = 1 All other frameworks default to is_fast_add = 0

-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:41 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

9:14 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

9:15 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

9:15 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

9:18 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

9:43 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #36 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks Andrew! The atomic update sets is_fast_add = 1 where frameworkcode = 'FA', but I wasn't sure if/how to set a default value for that in kohastructure.sql. It's my first time updating the database so I'm not 100% sure about that part. It can be handy setting it manually using ktd --dbshell UPDATE biblio_framework SET is_fast_add = 1 where frameworkcode = 'FA'; In ktd --shell if you run updatedatabase I think it sets it correctly. I agree that the standard FA framework deserves a little badge and should display under change Fast Add frameworks menu too. This is how it works when the data is correctly is_fast_add = 1 for 'FA' -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Nov 6 Nov

12:16 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #36)

...

In ktd --shell if you run updatedatabase I think it sets it correctly.

I just confirmed that this is the case. After applying the patch and running updatedatabase, the FA framework is properly marked as a fast add. I must have done something odd when testing earlier. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 Jan 18 Jan

12:35 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #38 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- 1. Can you add a check to your atomic update to make sure the column doesn't already exist? Something like: if ( !column_exists( 'biblio_framework', 'is_fast_add' ) ... 2. This is causing tests to fail. I think there should also be a new test to cover the change in Biblio.pm -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Jan 22 Jan

9:47 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

11 Feb 11 Feb

7 Mar 7 Mar

12:14 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA comment: Looks much. But should not be that hard. Good job. FAIL installer/data/mysql/atomicupdate/bug_32773.pl FAIL file permissions File must have the exec flag prove t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Biblio.t .. ok All tests successful. Files=1, Tests=40, 53 wallclock secs ( 0.07 usr 0.01 sys + 42.71 cusr 8.57 csys = 51.36 CPU) Result: PASS No blocker but small inconsistency: + `is_fast_add` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'the ability to be used as a Fast Add framework', + ALTER TABLE biblio_framework + ADD COLUMN is_fast_add TINYINT(1) NOT NULL DEFAULT 0 + AFTER frameworktext; You did not add the comment in the dbrev. No blocker too but a potential case problem. Look at git grep 'Fast Add' and git grep 'Fast add'. I feel that the latter is the correct one ? + <label for="is_fast_add">Use as a Fast Add framework: </label> + <span class="badge rounded-pill bg-secondary float-end">Fast Add</span> + [% !framework ? 'Default' : framework.frameworktext | html %] Not sure about this? Add parentheses to avoid confusion. + $frameworkcode eq 'FA' || $is_fast_add +if ( $frameworkcode eq 'FA' || $is_fast_add ) { + more occurrences Shouldnt this be just testing is_fast_add now ? + [% IF CAN_user_editcatalogue_edit_items or ( frameworkcode == 'FA' || is_fast_add and CAN_user_editcatalogue_fast_cataloging ) %] Think that this needs more parentheses to get the condition evaluation right. Here too in includes/cat-toolbar.inc ( frameworkcode == 'FA' || is_fast_add and CAN_user_editcatalogue_fast_cataloging ) %] More occurrences +my $frameworkcode = &GetFrameworkCode($biblionumber); +my $is_fast_add = + defined $frameworkcode && $frameworkcode ne '' + ? Koha::BiblioFrameworks->find($frameworkcode)->is_fast_add + : 0; Why call GetFrameworkCode if you have a $biblio object? Same here +my $fw = GetFrameworkCode($biblionumber); +my $is_fast_add = Koha::BiblioFrameworks->find($fw)->is_fast_add; +my $all_items = $biblio->items->search_ordered; -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:25 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #59 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the code review, Marcel! I'm working on addressing these concerns and will post updated patches soon. For Why call GetFrameworkCode if you have a $biblio object? It was already written like this in some other places like moredetail.pl so I just followed this pattern: my $fw = GetFrameworkCode($biblionumber); maybe in that case it is because $biblio could potentially be undefined? If you do have a biblio object, would it be better written as: my $frameworkcode = $biblio->frameworkcode; -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 Mar 14 Mar

12:32 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Brendan Lawlor from comment #59)

...

Thanks for the code review, Marcel!

I'm working on addressing these concerns and will post updated patches soon.

For Why call GetFrameworkCode if you have a $biblio object?

It was already written like this in some other places like moredetail.pl so I just followed this pattern: my $fw = GetFrameworkCode($biblionumber);

maybe in that case it is because $biblio could potentially be undefined?

If you do have a biblio object, would it be better written as: my $frameworkcode = $biblio->frameworkcode;

Sure. It is not a big deal. Just noting. The sub does even cache it. But when it is not yet cached, why go the database if you just have it at hand. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Aug 7 Aug

6:55 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

bugzilla-daemon＠bugs.koha-community.org

6:28 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

6:28 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

6:28 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186223|0 |1 is obsolete| | --- Comment #84 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 187055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187055&action=edit Bug 32773: Add fast cataloging support for multiple frameworks This set of patches adds a new is_fast_add column to biblio_framework. In Admin > MARC bibliographic frameworks admin users can add or edit frameworks to be used as Fast Add frameworks. Users with only fast_cataloging permission will be able to add records using those frameworks in the Fast Cataloging module. Test plan: Apply patches, restart_all and updatedatabase 1. Go to Admin > MARC Bibliographic frameworks 2. Edit/create a new framework and check the 'Use as Fast Add Framework' box 3. Also edit a framework and uncheck the 'Use as Fast Add Framework' box 4. Notice a 'Fast Add' badge is displayed in the table 5. Create a staff user with only fast_cataloging permissions 6. Log in as that user and go to Cataloging > Fast Cataloging 7. Confirm you can add a Fast Add record and items 8. Use the 'Settings' drop down to Change Fast Add framework 9. Confirm you see the frameworks that you set as Fast Add earlier 10. Confirm you can add the reocord and items 11. Log in as a superlibrarian and confirm that you can add records and items using standard frameworks and frameworks set as fast add Sponsored-by: CLAMS Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186224|0 |1 is obsolete| | --- Comment #85 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 187056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187056&action=edit Bug 32773: Add editing support for is_fast_add frameworks This patch uses the biblionumber to set is_fast_add on the catalog details page which is used to determine if the Edit button should be rendered in the cataloging toolbar. It updates the Biblio.pm subroutine can_be_edited to check if the biblio frameworkcode is 'FA' or if the biblio framework is_fast_add = 1. To test: 1. Set some biblio frameworks as Fast Add frameworks 2. Login as a user with fast_cataloging permissions only 3. Create and edit different types of Fast Add records 4. Add items and edit items 5. Confirm that you can only edit bibs and items for bibs where the framework is set as a Fast Add framework and the item is from your home library. 6. Log in as a superlibrarian 7. Confirm you can still create and edit records with the Default and other frameworks 8. Change a record's framework from a Fast Add to Default 9. Login as the user with only fast_cataloging confirm that you can no longer edit that record or its items Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

6:29 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

6:31 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #89 from Brendan Lawlor <blawlor@clamsnet.org> --- I just tested this again and I was getting a fail for the atomic update file needing the exec flag, so I added that and am re attaching the patches. Thanks! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Dec 17 Dec

10:43 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Michael Grgurev <mike.grgurev@mainlib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mike.grgurev@mainlib.org -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 Jan 8 Jan

8:55 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:11 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Status|Needs Signoff |Failed QA --- Comment #90 from Lisette Scheer <lisette@bywatersolutions.com> --- It no longer works for me to do a fast add frameworks other than the default with only fast add permission and database access. When I try to change the framework to another fast add framework I'm told I don't have permission. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

26 Jan 26 Jan

11:58 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

28 Jan 28 Jan

4:36 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Mar 6 Mar

7:59 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #109 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for testing Miranda! (In reply to Miranda Nero from comment #108)

...

I signed off but if anyone else needs to, the test plan step 5 should be updated to include edit_items permission as well.

This part is can be a little confusing to test, but the user with only fast_cataloging permissions is able to edit items that are on a fast add bib, but only for items owned by their home library. This is consistent with the way that permission works before the patch is applied. They shouldn't need the extra edit_items permission to edit those. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #110 from Miranda Nero <mnero@oslri.net> --- (In reply to Brendan Lawlor from comment #109)

...

Thanks for testing Miranda!

(In reply to Miranda Nero from comment #108)

...
I signed off but if anyone else needs to, the test plan step 5 should be updated to include edit_items permission as well.

This part is can be a little confusing to test, but the user with only fast_cataloging permissions is able to edit items that are on a fast add bib, but only for items owned by their home library. This is consistent with the way that permission works before the patch is applied. They shouldn't need the extra edit_items permission to edit those.

When I created a record with the fast add framework and did not have the edit_items permission, I was not able to create a new item. Turning on the edit_items permission allowed me to do so. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:23 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #111 from Miranda Nero <mnero@oslri.net> --- I just checked and see the difference. I'm used to seeing "New" in order to add an item to a record. I am able to add a one without edit_items, but I have to click Edit > Manage items in order to do so. The "New" button appears with the edit_items permission. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:44 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #112 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Miranda Nero from comment #111)

...

I just checked and see the difference. I'm used to seeing "New" in order to add an item to a record. I am able to add a one without edit_items, but I have to click Edit > Manage items in order to do so. The "New" button appears with the edit_items permission.

Yes exactly! Currently without edit_items permission you have to go to Manage items to get to edit them. There are a couple of small improvements in this patch that make it easier to get to the edit item page, for example the actions button appears in the table and the edit item link appeares below the barcodes on the items tab - only for items your library owns that are on a fast add bib of course. Thanks again for following up and your feedback! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:16 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

15 Apr 15 Apr

7:56 p.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:43 p.m.

11:11 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

bugzilla-daemon＠bugs.koha-community.org

8 May 8 May

9:44 p.m.

1:07 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #157 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 May 11 May

4:45 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

14 May 14 May

5:01 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42606 [Bug 42606] Error when importing a record using Z39.50 from the cataloging home page -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

18 May 18 May

10:59 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #158 from Jonathan Druart <jonathan.druart@gmail.com> --- Regression: we now get a 500 instead of "The record you requested does not exist" when you hit catalogue/detail.pl with a biblionumber that does not exist. `$biblio->frameworkcode` must be moved after `unless ($biblio) {` -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:33 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #159 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Jonathan Druart from comment #158)

...

Regression: we now get a 500 instead of "The record you requested does not exist" when you hit catalogue/detail.pl with a biblionumber that does not exist.

`$biblio->frameworkcode` must be moved after `unless ($biblio) {`

Thanks Jonathan! I filed bug 42637. Patch incoming -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:43 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42637 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42637 [Bug 42637] Check if biblio exists before checking if it is a fast add framework -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 May 24 May

4:49 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #160 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11 Jun 11 Jun

5:51 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Jul 28 Jul

5:55 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=43180 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5:55 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #161 from David Cook <dcook@prosentient.com.au> --- I haven't reviewed this one in depth, but how might it fit with bug 43180? That is, the idea of removing the "Delete" button from ACQ and FA frameworks? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:59 p.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #162 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to David Cook from comment #161)

...

I haven't reviewed this one in depth, but how might it fit with bug 43180? That is, the idea of removing the "Delete" button from ACQ and FA frameworks?

Since it now let's you create more than one Fast add framework, maybe it should not allow you to delete if it's the only is_fast_add framework? I didn't realize the ACQ framework is a hard coded system framework too. It definitely makes sense to have protection from deleting frameworks that would silently break special features. Maybe on biblio_framework.pl when $op eq 'delete_confirm', when it checks if there are any biblios attached with that framework, there could be some other checks added there too? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

29 Jul 29 Jul

6:02 a.m.

New subject: [Bug 32773] Have the ability to have more than 1 Fast Add framework

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32773 --- Comment #163 from David Cook <dcook@prosentient.com.au> --- (In reply to Brendan Lawlor from comment #162)

...

(In reply to David Cook from comment #161)

...
I haven't reviewed this one in depth, but how might it fit with bug 43180? That is, the idea of removing the "Delete" button from ACQ and FA frameworks?

Since it now let's you create more than one Fast add framework, maybe it should not allow you to delete if it's the only is_fast_add framework?

Yep, that sounds reasonable.

...

I didn't realize the ACQ framework is a hard coded system framework too. It definitely makes sense to have protection from deleting frameworks that would silently break special features.

...

Maybe on biblio_framework.pl when $op eq 'delete_confirm', when it checks if there are any biblios attached with that framework, there could be some other checks added there too?

Yeah that would be a good idea. -- You are receiving this mail because: You are watching all bug changes.

Age (days ago)

1303

Last active (days ago)

List overview

Download

237 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org