https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35005 Summary|Add subscription and order |Add warnings about |count to new batch record |subscriptions and orders |deletion tool |when deleting items --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Thibaud, I was excited to see this, but it turned out a little bit different to what I had expected: 1) The bug was filed for the 'batch record deletion tool'. Your patch deals with deleting single items. This can be fixed rather easily by changing the bug description and re-filing (see bug 35005) 2) For orders, I think we need to make some difference between an order that has been completed and one that is still pending. Deleting an item that is linked to a pending order would get us in trouble. Throwing out an old item purchased long ago not. Concerning order status would be: new, ordered, partial OK to delete: cancelled, complete 4) This line appears unrelated to the intention of the patch: + $i->{nomod} = 1 unless $patron->can_edit_items_from($item->homebranch); 5) The warnings messages you created are untranslatable, they need to be moved into the templates: cataloguing/additem.pl + if ($i_order) { + $warning_messages{$i->{itemnumber}} = sprintf('There is an order (ordernumber %s) on this item', $i_order->{ordernumber} ); + } + if ($i_serialid) { + $warning_messages{$i->{itemnumber}} = 'A subscription is linked to this item' 6) The subscription count on item batch modification doesn't seem to work right. I added a subscription and created an item on receiving an issue, so it's linked to the subscription. But it still said "None" on the batch mod page. 7) The order count on item batch modification doesn't appear to work either. I added an order with 'create items on order' and that item to the batch edit - The column remained at "None". 8) The notes work OK on the normal item editing form. I like the approach with the little warning sign. 9) QA tools are failing for a missing filter and tidiness. -- You are receiving this mail because: You are watching all bug changes.