http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44212&action=edit warning? This image shows that the patron owes money but it doesn't say that it won't be checking out - there are checkboxes next to all of the ones with error. Then when you confirm it shows you the same titles again but no title on the page to indicate that they did not in fact checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Here is a video of what I'm seeing as a big usability issue: http://screencast.com/t/lx6C2zKPxd -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 44343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44343&action=edit Bug 15091: Batch Checkout: Tell the user what happens while checking out This patch slightly changes the behaviour of Batch checkout. - If an item is successfully checked out, it is marked as such in column "Information" - If checkouts are confirmed and an item can not be checked out because e.g. the user reaches the fines threshold, an information is displayed in column "Information" To test: - Watch video from comment #2 - Apply both patches - Set sysprefs to allow override while checking out - Prepare a batch with invalid barcodes, with valid barcodes and with enough items that the user will reach the threshold while checking out all items - Verify that a title appears above the tables while performing the batch checkout - The first table "Batch checkout confirmation" should show - Items that could be checked out - Items that are not checked out (e.g. invalid barcode) - Items that need confirmation (e.g. debt) - After confirmation, more items should be checked out (as long the threshold is not reached - Items above the threshold will have a message "The patron has a debt..." Maybe a more sophisticated solution could be possible, but this patch should address the main concerns from comment #2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15116 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15116 [Bug 15116] show circ buttons at the top of batch circ page -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44343|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 44344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44344&action=edit Bug 15091: Batch Checkout: Tell the user what happens while checking out This patch slightly changes the behaviour of Batch checkout. - If an item is successfully checked out, it is marked as such in column "Information" - If checkouts are confirmed and an item can not be checked out because e.g. the user reaches the fines threshold, an information is displayed in column "Information" To test: - Watch video from comment #2 - Apply both patches - Set sysprefs to allow override while checking out - Prepare a batch with invalid barcodes, with valid barcodes and with enough items that the user will reach the threshold while checking out all items - Verify that a title appears above the tables while performing the batch checkout - The first table "Batch checkout confirmation" should show - Items that could be checked out - Items that are not checked out (e.g. invalid barcode) - Items that need confirmation (e.g. debt) - After confirmation, more items should be checked out (as long the threshold is not reached - Items above the threshold will have a message "The patron has a debt..." Maybe a more sophisticated solution could be possible, but this patch should address the main concerns from comment #2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44340|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44345&action=edit Bug 15091: Batch Checkout: Set titles above result tables This patch is to clarify the results that are displayed while performing a batch checkout. It is not the full solution for what is described in the video in comment #2, but it tells the user what the information in the table is about. A second patch is planned to address the case where the issues are confirmed but not can be fulfilled because the user's fines reach the threshold while checking out the items. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I don't think the second patch is the right way to fix this problem. It seems that the complete tool should be blocked if the patron is not able to check out. I will try to provide a counter patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44346|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44465&action=edit Bug 15091: Do not allow to use batch checkout if checkout is not allowed If the noissue param is passed to the template, the batch checkout should not be allowed. This patch globally fixes the problem raised by bug 15091. A generic message "cannot check out" is displayed and some more specific ones could be added later. For now it only trigger the "fine balance is over the limit" message. Test plan: Confirm there is no regression on the original behavior and that the issue raised on bug 15091 is fixed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #11 from Marc Véron <veron@veron.ch> --- Jonathan, I tested yout counter patch with following setting: a) Set loan fee for an item to 5.01 b) Set threshold to 10 c) Do a batch checkout (6 items) for a patron with 0 fines d) The 'Confirm checkout' dialog shows first item with no Information, following intems with information "The patron has a debt of 5.01" e) Click 'Checkout or renew' f) Message appears: "Cannot check out! Checkouts are BLOCKED because fine balance is OVER THE LIMIT." g) Go to Checkout page. 2 of the 6 items are checked out, charges now are on 10.02 This is almost the same confusing situation as described and screencasted by Nicole. With the patch I proposed and signed-off by Nicole, the user sees what happens. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44492&action=edit Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #15 from Marc Véron <veron@veron.ch> --- Hi Jonathan, If the patron is over the limit the message appears now as appropriate when going to tab "Batch checkout". One thing remains: There is no info in the information column about items that sucsessfully were checked out (like it was in my patch "Batch Checkout: Tell the user what happens while checking out"). The column "Information" now remains empty for sucessfully checked out items. See discussion with Nicole on IRC around: http://irc.koha-community.org/koha/2015-11-03#i_1750313 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com --- Comment #17 from Nicole Engard (ByWater) <nicole@bywatersolutions.com> --- I feel there are many improvements we could make here, but as it stands it's usable whereas before it was way too unclear. I'm okay with it going in this way and then us doing some improvements on look and feel and notifications. Nicole -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44492|0 |1 is obsolete| | --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 44959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44959&action=edit Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think there is a room for improvement here - I'd think to be really clear a positive messsage "checked out" and a negative message "not checked out" would really make things easier. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44981&action=edit [PASSED QA] Bug 15091: Batch Checkout: Set titles above result tables This patch is to clarify the results that are displayed while performing a batch checkout. It is not the full solution for what is described in the video in comment #2, but it tells the user what the information in the table is about. A second patch is planned to address the case where the issues are confirmed but not can be fulfilled because the user's fines reach the threshold while checking out the items. Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44983&action=edit [PASSED QA] Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.