[Bug 19713] New: 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Bug ID: 19713 Summary: 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 12513 t/db_dependent/UsageStats.t: OpacShowLibrariesPulldownMobile C4/UsageStats.pm: OpacShowLibrariesPulldownMobile Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513 [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 --- Comment #1 from priya.patel@catalyst.net.nz --- Created attachment 69870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69870&action=edit Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile To test: 1/ Grep to find OpacShowLibrariesPullDownMobile 2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm: 3/ Apply patch 4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2 files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 priya.patel@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |priya.patel@catalyst.net.nz Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69870|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 69893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69893&action=edit Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile To test: 1/ Grep to find OpacShowLibrariesPullDownMobile 2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm: 3/ Apply patch 4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2 files Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Priya! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69893|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69896&action=edit Bug 19713: Remove 2 occurances of OpacShowLibrariesPullDownMobile To test: 1/ Grep to find OpacShowLibrariesPullDownMobile 2/ Notice it is in t/db_dependent/UsageStats.t: and C4/UsageStats.pm: 3/ Apply patch 4/ Grep to check OpacShowLibrariesPullDownMobile was removed from 2 files Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |priya.patel@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Priya, you did not specify your lastname in the commit message, is it expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patch pushed to master for 18.05, congrats Priya for your first patch in! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org