http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Jorge de Cardenas <jdeca@smfpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdeca@smfpl.org --- Comment #1 from Jorge de Cardenas <jdeca@smfpl.org> --- I can confirm this behavior and it can have some serious consequences. I was working with the Self Checkout and was editing the SCOUserCSS. I have several entries similar to #selfCheckOutHeader. To get back to the SCOUserCSS I would search for "self". If I made any changes and saved, the word "self" would be dropped from any entry. Example: #selfCheckOutHeader would become #CheckOutHeader. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 --- Comment #3 from Fred P <fred.pierre@smfpl.org> --- Example: Search for "opac" in the global system preferences. The search term "opac" will mysteriously vanish from OPACUserCSS entries that contain the term. Our pseudo-class "#opac-main" becomes "#-main" The same thing happens when searching for self-checkout css. I am searching for SCO to change the SCOUserCSS. All of my css entries for SCOUserCSS show up with the letter combination "sco" edited out. The result of this bug is that when I re-save the css changes, my custom css breaks because the entries are saved as "-main" instead of "opac-main" or "selfhelp" instead of "scoselfhelp" The same thing happens to custom javascript code. For example in the SCOUserJS: "document.write(myscore);" becomes "document.write(myre);" The workflow at issue is: 1. Use the same term or letter combination in your custom css or javascript as part of the preference name. Enter your custom css and javascript in the global system preferences. 2. Search for the preference using part of the name. < Search term drops out of css and javascript > 3. Make a change to the preferences and save. < site css and javascript suddenly broken > -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 --- Comment #5 from Fred P <fred.pierre@smfpl.org> --- I believe the problem originates with this file: File: jquery.highlight-3.js Path: /home/koha/kohaclone/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins Removal of this function appears to resolve the issue, not sure about side-effects: -------------------------------------- jQuery.fn.removeHighlight = function() { return this.find("span.term").each(function() { this.parentNode.firstChild.nodeName; with (this.parentNode) { replaceChild(this.firstChild, this); normalize(); ----------------------------------------- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 --- Comment #7 from Fred P <fred.pierre@smfpl.org> --- Instead of editing jquery plug-ins, which may be referenced offsite, a simple edit to the Koha code fixes the problem. Needs testing, but I am not seeing any issues. Notice this function only affects the preferences table: File: preferences.js Path: /home/koha/kohaclone/koha-tmpl/intranet-tmpl/prog/en/js/pages if ( to_highlight ) { var words = to_highlight.split( ' ' ); $( '.prefs-tab table' ).find( 'td, th' ).not( '.name-cell' ).each( function ( i, td ) { $.each( words, function ( i, word ) { $( td ).highlight( word ) } ); - } ).find( 'option' ).removeHighlight(); } Replace the second-to-last line: + } ) } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 --- Comment #8 from Jorge de Cardenas <jdeca@smfpl.org> --- This seem to work disabling highlighting on both 'option' and 'textarea' File: preferences.js Path: /home/koha/kohaclone/koha-tmpl/intranet-tmpl/prog/en/js/pages if ( to_highlight ) { var words = to_highlight.split( ' ' ); $( '.prefs-tab table' ).find( 'td, th' ).not( '.name-cell').each( function ( i, td ) { $.each( words, function ( i, word ) { $( td ).highlight( word ) } ); } ).find( 'option, textarea' ).removeHighlight(); } changed .find( 'option' ).removeHighlight(); to .find( 'option, textarea' ).removeHighlight(); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14688&action=edit Bug 8401 : Highlighting of search terms in preference causes loss of data To test: 1/ Go to system preferences 2/ Go to SCOUserCSS 3/ Add #self 4/ Search for self 5/ Open SCOUserCSS 6/ Note it now contains only # (Do not click save) 7/ Apply the patch 8/ Refresh the page, and check SCOUserCSS and note it now says #self 9/ Rejoice! Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8401 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. Welcome to our 201st committer, Fred Pierre! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.