[Bug 43259] New: Add to group does not add to group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 Bug ID: 43259 Summary: Add to group does not add to group Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Steps to reproduce: 1 - Create a basket 2 - Create a group basket. At this step or the process : /cgi-bin/koha/acqui/basketgroup.pl clicking on "Add to group" does not add the basket to the group It is broken since 25.11.00. In 24.11, in basketgroups.tt there was an array named "grouped", to which the row containing the chosen element was added. It was created using : grouped = $("#grouped").DataTable($.extend(true, {}, dataTablesDefaults, { and row was added using grouped.row.add( row ).draw(); On main : $("#grouped").kohaTable(dt_params); row is added the same way : grouped.row.add( row ).draw(); This results in a JS error : "Uncaught TypeError: grouped.row is not a function" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | Keywords| |regression CC| |jonathan.druart@gmail.com Depends on| |38255 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38255 [Bug 38255] Do not use dataTable constructor directly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 204056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204056&action=edit Bug 43259: Fix add/remove basket to/from group Caused by commit e9b8004d197876dea8c38374c08ec00451e37020 Bug 38255: Replace dataTable constructor with kohaTable - Staff grouped and ungrouped should be DataTable objects. Test plan: Create a basket, close it Create a basket group and test the "Add to group" and "Remove" button on the basket group edit view Without this patch there was a JS error: "Uncaught TypeError: grouped.row is not a function" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204056|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 204068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204068&action=edit Bug 43259: Fix add/remove basket to/from group Caused by commit e9b8004d197876dea8c38374c08ec00451e37020 Bug 38255: Replace dataTable constructor with kohaTable - Staff grouped and ungrouped should be DataTable objects. Test plan: Create a basket, close it Create a basket group and test the "Add to group" and "Remove" button on the basket group edit view Without this patch there was a JS error: "Uncaught TypeError: grouped.row is not a function" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding baskets release notes| |to basket groups for | |acquisitions (Acquisitions | |> [select a vendor] > Bask | |groups). | | | |Before this patch, | |attempting to "Add to | |group" or "Remove" a basket | |to a basket group did not | |work - nothing happened | |(and generated a JavaScript | |error in the browser | |console). | | | |Now, baskets can be | |successfully added or | |removed from basket groups. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43259 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org