[Bug 21580] New: Order creation for edifact vendor fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Bug ID: 21580 Summary: Order creation for edifact vendor fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The loop generating orders for vendors with auto_orders set fails as only one of the required two parameters is passed to create_edi_order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 80662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80662&action=edit Add a test for message buyer_ean method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 80663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80663&action=edit pass the buyer_ean to order routine Call of the subroutine now matchs documentation and passes parameter validation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Colin Campbell from comment #2)
Created attachment 80663 [details] [review] pass the buyer_ean to order routine
Call of the subroutine now matchs documentation and passes parameter validation
Hi, is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Order creation for edifact |Order creation for EDIFACT |vendor fails |vendor fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 93674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93674&action=edit Bug 21580 Add test for message buyer_ean method Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 93675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93675&action=edit Bug 21580 Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #80662|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80663|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93943&action=edit Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93674|0 |1 is obsolete| | Attachment #93675|0 |1 is obsolete| | Attachment #93943|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93944&action=edit Bug 21580: Add test for message buyer_ean method Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93945&action=edit Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Passing QA on this as agreed with RM - both parties heavily using EDIFACT have been involved in the QA process. Tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org