[Bug 22695] New: Remove non-XSLT search results view from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Bug ID: 22695 Summary: Remove non-XSLT search results view from the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: katrin.fischer@bsz-bw.de, nick@bywatersolutions.com, testopia@bugs.koha-community.org Blocks: 12561 Target Milestone: --- There are no bugs blocking the removal of the non-XSLT search results view in the staff client, so it is safe to remove. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87910&action=edit Bug 22695: Remove non-XSLT search results view from the staff client This patch removes the option to select non-XSLT search results in the staff client. The patch removes the markup from the template, updates the system preference options, and modifies Search.pm so that OPAC and staff client results XSLT functions are not tied together. To test, apply the patch and set the XSLTResultsDisplay to a blank value. Run the database update. The value of the XSLTResultsDisplay system preference should now be "default." Perform a catalog search in the staff client. The results should be shown using the XSLT view. Test that OPAC search results respect the OPACXSLTResultsDisplay preference when enabled and disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22697 [Bug 22697] Reindent catalogue/result.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87910|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 87930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87930&action=edit Bug 22695: Remove non-XSLT search results view from the staff client This patch removes the option to select non-XSLT search results in the staff client. The patch removes the markup from the template, updates the system preference options, and modifies Search.pm so that OPAC and staff client results XSLT functions are not tied together. To test, apply the patch and set the XSLTResultsDisplay to a blank value. Run the database update. The value of the XSLTResultsDisplay system preference should now be "default." Perform a catalog search in the staff client. The results should be shown using the XSLT view. Test that OPAC search results respect the OPACXSLTResultsDisplay preference when enabled and disabled. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-marc.thibault@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87930|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen@inlibro.com> --- Created attachment 87937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87937&action=edit Bug 22695: Remove non-XSLT search results view from the staff client This patch removes the option to select non-XSLT search results in the staff client. The patch removes the markup from the template, updates the system preference options, and modifies Search.pm so that OPAC and staff client results XSLT functions are not tied together. To test, apply the patch and set the XSLTResultsDisplay to a blank value. Run the database update. The value of the XSLTResultsDisplay system preference should now be "default." Perform a catalog search in the staff client. The results should be shown using the XSLT view. Test that OPAC search results respect the OPACXSLTResultsDisplay preference when enabled and disabled. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87937|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 87992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87992&action=edit Bug 22695: Remove non-XSLT search results view from the staff client This patch removes the option to select non-XSLT search results in the staff client. The patch removes the markup from the template, updates the system preference options, and modifies Search.pm so that OPAC and staff client results XSLT functions are not tied together. To test, apply the patch and set the XSLTResultsDisplay to a blank value. Run the database update. The value of the XSLTResultsDisplay system preference should now be "default." Perform a catalog search in the staff client. The results should be shown using the XSLT view. Test that OPAC search results respect the OPACXSLTResultsDisplay preference when enabled and disabled. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Marking as an enhancement as it's a cleanup piece which 'might' surprise users of the stable branch. Will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org