[Bug 36581] New: Checkouts table on patron account won't load if any of the items have item notes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Bug ID: 36581 Summary: Checkouts table on patron account won't load if any of the items have item notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The checkouts table hangs if any of the checked-out items have public or nonpublic notes, and causes a console error: Uncaught ReferenceError: ymd is not defined ymd is defined in document ready - presumably this broke when the checkouts table got refactored into its own function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164760&action=edit Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164760|0 |1 is obsolete| | --- Comment #2 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 164761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164761&action=edit Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Trivial one-line patch - self-SO -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164761|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164775&action=edit Bug 36581: Define ymd in scope for checkouts table Test plan: 1. Find or create an item with a public or nonpublic note (in KTD default data, items on biblionumber 12 have notes already) 2. Check the item out to a patron --> Checkouts table loading never completes --> Browser console shows: "Uncaught ReferenceError: ymd is not defined" 3. Apply patch and clear browser cache 4. Refresh the page --> Checkout table loads and console error is gone Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I suspect this is from the CSRF, but we should test this in older versions or uncover the fault -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Nick Clemens from comment #5)
I suspect this is from the CSRF, but we should test this in older versions or uncover the fault
I think it's bug 35506. I'll test and confirm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35506 --- Comment #7 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Emily Lamancusa from comment #6)
(In reply to Nick Clemens from comment #5)
I suspect this is from the CSRF, but we should test this in older versions or uncover the fault
I think it's bug 35506. I'll test and confirm.
Confirmed - I'll add it a dependency. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 [Bug 35506] selenium/regressions.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Bug 36581 depends on bug 35506, which changed state. Bug 35506 Summary: selenium/regressions.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35506 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue that release notes| |prevented a patron's | |checkouts table from | |loading if any of their | |checked-out items had | |public or nonpublic notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36581 Bug 36581 depends on bug 35506, which changed state. Bug 35506 Summary: selenium/regressions.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org