[Bug 12672] New: GetMARCISBN should return the corresponding subfield
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bug ID: 12672 Summary: GetMARCISBN should return the corresponding subfield Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Currently, if you call GetMARCISBN for a record that contains another subfield than $a (for example 020$c in MARC21) GetMARCISN returns all the subfields appended. As the function is used for visualization purposes, it should be fixed to only show the ISBN subfield. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |tomascohen@gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30295&action=edit Bug 12672: (regression test) GetMarcISBN should return the corresponding subfield Run: $ prove -v t/db_dependent/Biblio.t => FAIL: GetMarcISBN doesn't return the expected value for ISBN in MARC21, NORMARC and UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30296&action=edit Bug 12672: GetMarcISBN should return the corresponding subfield The current GetMarcISBN implementation returns an array of ISBN in which all subfields of a ISBN field occurence are appended. For example, in MARC21, if you have $a and $c defined, they will be appended for output. This happens for $z. To reproduce: - Run the regression tests attached to this bug. To test: - Apply the patch, regression tests pass. - Sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12554 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetMARCISBN should return |GetMarcISBN should return |the corresponding subfield |the corresponding subfield -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30295|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30346&action=edit [SIGNED-OFF] Bug 12672: (regression test) GetMarcISBN should return the corresponding subfield Run: $ prove -v t/db_dependent/Biblio.t => FAIL: GetMarcISBN doesn't return the expected value for ISBN in MARC21, NORMARC and UNIMARC Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test fails, no koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30296|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30347&action=edit [SIGNED-OFF] Bug 12672: GetMarcISBN should return the corresponding subfield The current GetMarcISBN implementation returns an array of ISBN in which all subfields of a ISBN field occurence are appended. For example, in MARC21, if you have $a and $c defined, they will be appended for output. This happens for $z. To reproduce: - Run the regression tests attached to this bug. To test: - Apply the patch, regression tests pass. - Sign off Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Now test pass, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmc@esilibrary.com, | |jcamins@cpbibliography.com, | |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I am not sure about removing $z - invalid/cancelled ISBN. Adding Jared and Galen in cc, looking for opinions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to Katrin Fischer from comment #5)
Hm, I am not sure about removing $z - invalid/cancelled ISBN.
Adding Jared and Galen in cc, looking for opinions.
My inclination is that $z shouldn't appear, because it doesn't provide useful -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to Jared Camins-Esakov from comment #6)
My inclination is that $z shouldn't appear, because it doesn't provide useful
[whoops, somehow submitted before I finished] ... doesn't provide useful information in the majority of situations, but could easily confuse someone looking for the ISBN. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30346|0 |1 is obsolete| | Attachment #30347|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30502&action=edit [PASSED QA] Bug 12672: (regression test) GetMarcISBN should return the corresponding subfield Run: $ prove -v t/db_dependent/Biblio.t => FAIL: GetMarcISBN doesn't return the expected value for ISBN in MARC21, NORMARC and UNIMARC Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Test fails, no koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30503&action=edit [PASSED QA] Bug 12672: GetMarcISBN should return the corresponding subfield The current GetMarcISBN implementation returns an array of ISBN in which all subfields of a ISBN field occurence are appended. For example, in MARC21, if you have $a and $c defined, they will be appended for output. This happens for $z. To reproduce: - Run the regression tests attached to this bug. To test: - Apply the patch, regression tests pass. - Sign off Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Now test pass, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12672 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org