[Bug 17252] New: Koha::AuthorisedValues - Remove GetAuthorisedValueByCode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Bug ID: 17252 Summary: Koha::AuthorisedValues - Remove GetAuthorisedValueByCode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55188&action=edit Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251 [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17253 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253 [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55188|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55519&action=edit Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55519|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56245&action=edit Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56245|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56282&action=edit Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56282|0 |1 is obsolete| | --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 56296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56296&action=edit Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56296|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56398&action=edit [PASSED QA] Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Loving to cleaner code this tree is moving to :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56402&action=edit [PASSED QA] Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping This subroutine was only used once in GetItemsForInventory. It can be replaced with a quite simple search on AV join on authorised_value_categories and marc_subfield_structures tables. Note that the "interface" parameter was always set to "staff" and was useless. Test plan: Play with the inventory and confirm that the AV descriptions are correctly displayed. The tests in t/db_dependent/Items/GetItemsForInventory.t cover this change and should still pass. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56398|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56403&action=edit [PASSED QA] Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode The subroutine C4::Koha::GetAuthorisedValueByCode returned the description (staff or opac) for a given authorised value. Note that we may need a unique key to ->find instead of ->search. Test plan: - Checkin an item that cannot be checked in because it's lost, the message should display the AV description - Generate a letter with borrowers.streettype equals an ROADTYPE AV, the description should be displayed. - Edit a patron attribute type, the AV dropdown list should be displayed - Create the PA_CLASS AV category (see bug 7154) and make sure it behaves as before when editing a patron - The checkout list should display descriptions for LOC, LOST and DAMAGED Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- ack.. wrong bug.. already qa'd this one five minutes ago. ignore last two comments and the double commit line.. will clean that back out now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56402|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5880 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org