[Bug 28302] New: Koha does not work with CGI::Compile 0.24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Bug ID: 28302 Summary: Koha does not work with CGI::Compile 0.24 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit » Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. I suggest to just forbid CGI::Compile 0.24 in cpanfile (patch coming soon) Warning for Ubuntu Focal users: the packaged version of CGI::Compile is 0.24 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 120704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120704&action=edit Bug 28302: Forbid CGI::Compile 0.24 CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit » Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. Test plan: 1. Reproduce the bug 2. Install CGI::Compile 0.25 and restart starman 3. Make sure the bug is gone :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate CC| |mtj@kohaaloha.com Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Julian Maurice from comment #0)
Warning for Ubuntu Focal users: the packaged version of CGI::Compile is 0.24
Yikes... According to https://packages.ubuntu.com/search?keywords=libcgi-compile-perl&searchon=names, the only bad one is focal 20.04. I'll raise an issue with Ubuntu. I don't think forbidding CGI::Compile 0.24 is going to be practical for Koha users. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- https://bugs.launchpad.net/ubuntu/+source/libcgi-compile-perl/+bug/1927882 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- So... I think that it would be OK to sign this off. For Ubuntu Focal, we should package CGI::Compile 0.25. That doesn't need to happen in the Koha codebase, so it's not a blocker here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120704|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 120952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120952&action=edit Bug 28302: Forbid CGI::Compile 0.24 CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit » Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. Test plan: 1. Reproduce the bug 2. Install CGI::Compile 0.25 and restart starman 3. Make sure the bug is gone :) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works :) about.pl shows as expected that 0.24 is forbidden 0.24 vs 0.25 give the expected authority test results and logs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Test notes: install version 0.24: cpanm RKITOVER/CGI-Compile-0.24.tar.gz remove version from package manager without removing dependencies and packages whose CGI::Compile is a dep (basically uninstalls all Koha stuff) sudo dpkg -r --force-depends libcgi-compile-perl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28354 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120952|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120976&action=edit Bug 28302: Forbid CGI::Compile 0.24 CGI::Compile 0.24 has a bug: https://github.com/miyagawa/CGI-Compile/issues/25 It can cause weird bugs, like breaking the authority detail display after trying to modify an authority. Steps to reproduce: 1. Install CGI::Compile 0.24 2. Restart starman with only 1 worker 3. Go to the detail page of an authority (authorities/detail.pl) 4. Go to the edit page (Edit » Edit record) 5. Check starman logs, you should see "Subroutine build_tabs redefined at [...]" 6. Click on cancel to go back to the detail page, which should now show a "blank" authority. Now the only way to get the authority back is to restart starman. Test plan: 1. Reproduce the bug 2. Install CGI::Compile 0.25 and restart starman 3. Make sure the bug is gone :) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Created attachment 121183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121183&action=edit Bug 28302: Update packages to ignore CGI::Compile 0.24 to test... 1/ build package 2/ install package on focal 3/ check that libcgi-compile-perl 0.24 is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Should it not be backported to 20.05 meanwhile? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #12)
Should it not be backported to 20.05 meanwhile?
yes, this should be backported to 20.05 and 19.11 too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Created attachment 121243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121243&action=edit Bug 28302: Update packages to ignore CGI::Compile 0.24 (2) to test... 1/ build package 2/ install package on focal 3/ check that libcgi-compile-perl 0.24 is not installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- 2 Follow-ups pushed to 20.11.x for 20.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06 |21.05.00,20.11.06,20.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12 |21.05.00,20.11.06,20.05.12, released in| |19.11.18 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- No cpanfile on 19.11.x so I only backported: Bug 28302: Update packages to ignore CGI::Compile 0.24 Bug 28302: Update packages to ignore CGI::Compile 0.24 (2) Was that the right choice? Backported: Pushed to 19.11.x branch for 19.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #20 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #19)
No cpanfile on 19.11.x so I only backported: Bug 28302: Update packages to ignore CGI::Compile 0.24 Bug 28302: Update packages to ignore CGI::Compile 0.24 (2)
Was that the right choice?
yes :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Mason James from comment #20)
(In reply to Victor Grousset/tuxayo from comment #19)
No cpanfile on 19.11.x so I only backported: Bug 28302: Update packages to ignore CGI::Compile 0.24 Bug 28302: Update packages to ignore CGI::Compile 0.24 (2)
Was that the right choice?
yes :)
Shouldn't it have been added to PerlDependencies then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #22 from Mason James <mtj@kohaaloha.com> --- Created attachment 121465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121465&action=edit Bug 28302: Update PerlDependencies.pm to CGI::Compile 0.25 (19.11.x) to test... 1/ apply patch 2/ build package 3/ view about.pl to check CGI::Compile 0.25 version is satisfied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #21)
(In reply to Mason James from comment #20)
(In reply to Victor Grousset/tuxayo from comment #19)
No cpanfile on 19.11.x so I only backported: Bug 28302: Update packages to ignore CGI::Compile 0.24 Bug 28302: Update packages to ignore CGI::Compile 0.24 (2)
Was that the right choice?
yes :)
Shouldn't it have been added to PerlDependencies then?
ah yes, thanks. i've added a patch Victor, if you push this patch for a tiny 19.11.19 release, i can build the package -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Pushed in 19.11.18-2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.06,20.05.12, |21.05.00,20.11.06,20.05.12, released in|19.11.18 |19.11.18-2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28302 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |CLOSED --- Comment #25 from Mason James <mtj@kohaaloha.com> --- (In reply to Victor Grousset/tuxayo from comment #24)
Pushed in 19.11.18-2
thanks Victor, closing :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org