https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48985&action=edit Bug 16052: Styling buttons To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons and behave as expected 4) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I think these buttons look good. However, my desire for logical consistency makes me wonder whether they are the correct thing to use here. Usually we use buttons to signify an action which is performed "with" something: Submitting a form, usually. These buttons are navigational. If a plain link doesn't feel right, do we need to think about introducing a new style that is neither a plain link nor a button? And how would that fit in with other areas that have something similar? I also think we need to think about the use of "back" links, not just where but anywhere they are used. In this case "back" might more accurately be labeled "Stage more MARC records?" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48985|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49071&action=edit Bug 16052: Putting buttons from after MARC records have been staged into a toolbar To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage more MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I think this is a great solution! I have a couple of suggestions, though. 1. I don't think this needs a separate include file because it only appears in one place. 2. I think the "Stage" button should go on the left to reflect left-to-right, first step, second step. 3. I think the "Stage" button should say "Stage MARC records." I realize it only appears after you've completed a staging process, but it feels wrong to have the "more" in there. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49150|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49152&action=edit Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49152|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49171&action=edit [SIGNED-OFF] Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thank you, this is a great improvement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16052 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49171|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49201&action=edit Bug 16052: Putting buttons from after MARC records have been staged into a toolbar EDIT: Incorporating Owen Leonard's changes from Comment 6 To test: 1) Go to Tools -> Stage MARC records for import 2) Upload any file and click Stage for import once it has uploaded 3) Confirm both links are now buttons in a toolbar and work as expected 4) Notice that 'Stage MARC records' (what was once the 'Back' button) now takes you back to stage-marc-records.pl instead of tools-home.pl 5) Also confirm that the space between results and colon (MARC staging results :) is gone Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thank you, this is a great improvement. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.