[Bug 8304] New: composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Priority: P5 - low Change sponsored?: --- Bug ID: 8304 Assignee: gmcharlt@gmail.com Summary: composed authorities Rameau management Severity: enhancement Classification: Unclassified OS: All Reporter: matthias.meusburger@biblibre.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 10453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10453&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10453|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 11046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11046&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- This new patch removes the reindenting changes, making the patch easier to read and to understand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11046|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 12081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12081&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) Rebased patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- While this feature is very promising, it does not cope well with multiple subfield authorities. If I change an authority with the following main entry: =150 ##$aActors$zUnited States$vBiography to =150 ##$aActors$zUnited States$vBiographies the bib records end up with the heading: =650 ##$zUnited States$aActors$zUnited States$vBiographies Notice the extra $z at the front. Also, I noticed if your single-subfield heading is out of sync on the bib record, sometimes you end up with two identical subfields in the bib record. I'm not entirely sure what causes that, though, as it doesn't seem to happen 100% of the time. Also note that in order to test this you must first apply the fix for bug 8743. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- If you added a syspref so that libraries using precomposed headings could disable the automatic composition, that would probably be enough for MARC21/NORMARC authority merging to resume working. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #7 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 14112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14112&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #8 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- (Rebased patch) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #9 from laurenthdl <henridamien.laurent@biblibre.com> --- Created attachment 14308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14308&action=edit biblio record This file contains UNIMARC bibliorecords as example -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #10 from laurenthdl <henridamien.laurent@biblibre.com> --- Created attachment 14309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14309&action=edit authorities linked to biblio records Beware that when importing, the authorities ids may change. So you may have to change the related imported records. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 laurenthdl <henridamien.laurent@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14112|0 |1 is obsolete| | --- Comment #11 from laurenthdl <henridamien.laurent@biblibre.com> --- Created attachment 14564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14564&action=edit New version for patch Introduces two new fields in need_merge -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |sophie.meynieux@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com --- Comment #12 from Pierre Angot <tredok.pierre@gmail.com> --- Hello, I've tested with files added by Henri-Damien on sandbox (http://pro.pelardon.biblibre.com test/test) - search authorities "Littérature sentimentale", edit it and modify 250$a (Harlequin champion de l'amour) - search catalog "100 romans d'amour" - check 606 - No change : 606$a is still "Littérature sentimentale". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #13 from Pierre Angot <tredok.pierre@gmail.com> --- The syspref "dontmerge" wasn't activated ^^ I've made a little modification, and it's ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 15849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15849&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15849|0 |1 is obsolete| | --- Comment #16 from stephane.delaune@biblibre.com --- Created attachment 16784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16784&action=edit Bug 8304 : composed authorities Rameau management patch rebased on master due to Bug 5635 integration. Basic rebase, keeping signed-off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 stephane.delaune@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16784|0 |1 is obsolete| | --- Comment #17 from stephane.delaune@biblibre.com --- Created attachment 16790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16790&action=edit Bug 8304 : composed authorities Rameau management fix bad POD already present before this commit. This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #18 from Pierre Angot <tredok.pierre@gmail.com> --- I've tested on sandbox : - search authorities "Poésie", edit it and modify 250$a (Poésie jolie) - search catalog "Le buveur d'étoiles" - check 606 - search authorities "Romain", edit it and modify 250$a (Romain test) - search catalog "Au temps des romains" - check 606 Everything is ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 18325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18325&action=edit Bug 8304 : composed authorities Rameau management This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 1/ There is no unit tests for new subroutines introduced in C4::Charset and C4::AuthoritiesMarc packages. 2/ There is no call to C4::Charset::SanitizeEntity, where it is used? 3/ The C4::AuthoritiesMarc::_process_subfcode_4_merge checks if a string exists: q{S'emploie uniquement en subdivision chronologique} but there is no comment to explain what is it. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18450&action=edit Bug 8304: UT for new subroutines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- 3 unit tests in t/Charset do not pass, I think there is a bug in C4::Charset::SanitizeEntity. I cannot provide unit tests for the C4::AuthoritiesMarc::_process_subfcode_4_merge routine, I don't understand what it does. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10298 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #24 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I don't know what _process_subfcode_4_merge does, but it is only dealing with some fields (600, 606, 607, 700, 701, 710, 711, 712). Maybe it should deal other subject fields (like 604, 605, 608, 616) ? M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Bug 8304 depends on bug 10298, which changed state. Bug 10298 Summary: t::lib::Mocks tries to deal with syspref but doesn not manage to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #25 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- The patch adds in merge() : + DelAuthority($mergefrom) if ( $mergefrom != $mergeto ); This is a big difference and I think is not necessary because codes calling merge() call this method when necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |claire.hernandez@biblibre.c | |om Resolution|--- |DUPLICATE --- Comment #26 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- Has been replaced by http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 *** This bug has been marked as a duplicate of bug 14560 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org