[Bug 24064] New: DUEDGST typoed as DUEGST
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Bug ID: 24064 Summary: DUEDGST typoed as DUEGST Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus@libriotech.no Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Attachment 86382 of bug introduces a typo in the letter code DUEDGST: - my $letter_type = 'DUEDGST'; + letter_code => 'DUEGST', This causes "Item Due Reminder (Digest)" messages not to be sent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Hm, that should be bug 20478. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But 20478 is not in 18.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 95532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95532&action=edit Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #2)
But 20478 is not in 18.11?
No, Martin wrote: "Enhancement will not be backported to 18.11.x series." How so? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Ah, the version was set to 18.11? Dunno how that happened... Set it to master now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95532|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 95539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95539&action=edit Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |20478 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by commit e18626b6f142128064317e95ef4a7fb089f4f48d Bug 20478: Refactor to remove code duplication. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 [Bug 20478] Advance notices: send separate digest messages per branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That sucks! What about the notices in the DB? :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jonathan Druart from comment #8)
What about the notices in the DB? :-/
letters or message_queue? None of them should be affected, except that since DUEGST is not found in letters, no DUE(D)GST messages will end up in message_queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95539|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95547&action=edit Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org