[Bug 33721] New: Show inactive funds in invoice.tt out of order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Bug ID: 33721 Summary: Show inactive funds in invoice.tt out of order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Created attachment 151100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151100&action=edit Screenshot of the invoice section with the fund line When viewing an invoice, the elements in the 'Fund' line are out of order. The is the 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 151171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151171&action=edit Bug 33721: Fix display of shipping cost/fund on invoice summary page When viewing an invoice, the elements in the 'Fund' line were out of order: 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be: 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. This copies the markup that is used when you click on "Receive shipment". It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order 4. Apply patch 5. Verify the order is now fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151171|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 151177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151177&action=edit Bug 33721: Fix display of shipping cost/fund on invoice summary page When viewing an invoice, the elements in the 'Fund' line were out of order: 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be: 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. This copies the markup that is used when you click on "Receive shipment". It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order 4. Apply patch 5. Verify the order is now fixed Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Barbara! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151177|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 151342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151342&action=edit Bug 33721: Fix display of shipping cost/fund on invoice summary page When viewing an invoice, the elements in the 'Fund' line were out of order: 'Fund:' label, followed by 'Show inactive:' label, then the fund drop-down and then the show inactive checkbox. The order should be: 'Fund:' label, fund drop-down, 'Show inactive:' label, show inactive checkbox. This copies the markup that is used when you click on "Receive shipment". It also changes 'Fund' to 'Shipping fund' to bring the forms even more in line. To recreate: 1. In acquisitions, create an order and close the basket 2. Click 'Receive shipment' and receive the order 3. Click 'Finish receiving' --> The Fund line in invoice.tt is out of order 4. Apply patch 5. Verify the order is now fixed Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 [Bug 34452] Button 'Update adjustments' is hidden -- You are receiving this mail because: You are watching all bug changes.
git grep 'Show inactive:</label>' koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt: <label for="all_showallbudgets"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah OK all places use style in label tag : style="float:none;width:auto;"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt: <label for="all_showallbudgets" style="float:none;width:auto;margin-right:0;"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt: <label for="showallfunds" style="float:none;width:auto;"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: <label for="showallbudgets" style="float:none;"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: <label for="showallbudgets"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt: <label for="showallfunds" style="float:none;width:auto;"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt: <label for="showallbudgets" style="float:none;"> Show inactive:</label> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt: <label for="showallfunds" style="float:none;width:auto;"> Show inactive:</label> It would be better to use a class and CSS rule in staff file. For another bug report of course ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34492 [Bug 34492] Fund in adjustments is now shipping fund -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org