[Bug 21878] New: Opac pagination problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Bug ID: 21878 Summary: Opac pagination problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kohadevinim@devinim.com.tr QA Contact: testopia@bugs.koha-community.org After changing uri filter opac pagination problem occured. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 --- Comment #1 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82617&action=edit Bug 21878: To fix pagination problem in OPAC Due to conversions from html to uri in various places pagination in OPAC doesnot work properly. This change will resolve pagination problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21526 |21706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 [Bug 21706] Editing subfields in authority frameworks is broken (TT filter) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21706 |21526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21706 [Bug 21706] Editing subfields in authority frameworks is broken (TT filter) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Needs Signoff |BLOCKED --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Bug 21878 depends on bug 21526, which changed state. Bug 21526 Summary: TT variables used to build a link should be uri filtered https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Assignee|oleonard@myacpl.org |kohadevinim@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Opac pagination problem |Fix few links for opac | |pagination and facets (no | |uri filter) Severity|minor |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82617|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82630&action=edit Bug 21878: To fix pagination problem in OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82631&action=edit Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history We need to replace the uri filter on query_cgi to make some URLs work. Test plan: Check if the links on user page, search history work for biblio and auth in current and previous release. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82632&action=edit Bug 21878: (follow-up) Fix a few uri filter in facets We need to adjust a few query_cgi | uri filters here too. Note that sort_by should be filtered by uri, not url. Similar change on staff side. Test plan: Toggle Show all items/Limit available items. Check: git grep -l "query_cgi | uri" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82630|0 |1 is obsolete| | Attachment #82631|0 |1 is obsolete| | Attachment #82632|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82643&action=edit Bug 21878: To fix pagination problem in OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82643|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82644&action=edit Bug 21878: To fix pagination problem in OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82645&action=edit Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history We need to replace the uri filter on query_cgi to make some URLs work. Test plan: Check if the links on user page, search history work for biblio and auth in current and previous release. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 82646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82646&action=edit Bug 21878: (follow-up) Fix a few uri filter in facets We need to adjust a few query_cgi | uri filters here too. Note that sort_by should be filtered by uri, not url. Similar change on staff side. Test plan: Toggle Show all items/Limit available items. Check: git grep -l "query_cgi | uri" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950 [Bug 21950] Opac search with accented words error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- depends on 13618, not backporting to 18.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org