[Bug 38661] New: Add warning when deleting import batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Bug ID: 38661 Summary: Add warning when deleting import batch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs@lists.koha-community.org Reporter: bernard.scaife@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org If a user deletes a Manage staged MARC records batch which is associated with imported records, they lose the ability to roll back the attached records. Sometimes this will be the intention, but other times they will simply have forgotten to revert a test import and those records are then impossible to roll-back. Could we have a warning message when deleting a batch with attached records such as "There are x imported records attached to this batch which cannot be reverted if you proceed. Do you wish to continue and delete the batch record?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 --- Comment #1 from Bernard <bernard.scaife@openfifth.co.uk> --- Created attachment 183872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183872&action=edit Bug 38661: Add warning when deleting import batch When a batch is cleaned from the staged marc records screen, the user may be unaware of records that are imported within the batch which they may want to revert in future. Cleaning the batch unlinks these Test plan: 1. Stage a marc record from a mrc file 2. Import the batch 3. Return to the managed staged records screen. 4. Click "clean" 5. Note message is "Clear all reservoir records staged in this batch? This cannot be undone." 6. Apply patch and restart all. 7. Repeat steps 1-4 with a new batch 8. Note message has changed to "This batch contains imported records. Are you sure you wish to clear all the reservoir records? This cannot be undone." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183872|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183888&action=edit Bug 38661: Add warning when deleting import batch When a batch is cleaned from the staged marc records screen, the user may be unaware of records that are imported within the batch which they may want to revert in future. Cleaning the batch unlinks these and makes reversion / cleanup difficult. This patch gives an extra warning when cleaning a batch where there are still linked records attached. Test plan: 1. Stage a marc record from a mrc file 2. Import the batch 3. Return to the managed staged records screen. 4. Click "clean" 5. Note message is "Clear all reservoir records staged in this batch? This cannot be undone." 6. Apply patch and restart all. 7. Repeat steps 1-4 with a new batch 8. Note message has changed to "This batch contains imported records. Are you sure you wish to clear all the reservoir records? This cannot be undone." Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183889&action=edit Bug 38661: (follow-up) Eliminate duplicate ids The id attribute should be unique on the page, so I'm changing it to a name attribute and updating the corresonding selector. Also, we can eliminate find() here: $(this).closest('form').find('input... ...because $(this) IS the form, so we can optimize a tiny bit by removing the find(). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Should this be 'Passed QA'? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bernard.scaife@openfifth.co |ity.org |.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The changes here are minimal and everything looks good, keeping this as PQA even though it seems to lacking a proper QA. I'll consider it QA'ed by me. :) Please add release notes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38661 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org