[Bug 22632] New: Add logging of merged patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Bug ID: 22632 Summary: Add logging of merged patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- When patrons are merged, we don't retain any record of that merging. One patron is retained and the other goes into deletedborrowers and that's it. It's be great to be able to somehow identify if a current patron was previously merged and which deleted patron they were merged with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |axel.amghar@gmail.com |ity.org | CC| |axel.amghar@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #1 from axel <axel.amghar@gmail.com> --- Created attachment 87778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87778&action=edit without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #2 from axel <axel.amghar@gmail.com> --- Created attachment 87920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87920&action=edit Bug 21003: Made Edit keywords more consistent in add_items-step2.tt When adding a course reserve with a barcode that already exists, the title, breadcrumbs, and legend of the form all specify that the user is editing, and not adding, the book. Test plan: Same as comment 1 Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think something went wrong here with the patch attached. Obsoleting the last one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #4 from axel <axel.amghar@gmail.com> --- Created attachment 87921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87921&action=edit Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #5 from axel <axel.amghar@gmail.com> --- Created attachment 87922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87922&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #6 from axel <axel.amghar@gmail.com> --- Created attachment 87923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87923&action=edit Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #7 from axel <axel.amghar@gmail.com> --- Created attachment 87926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87926&action=edit adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87922|0 |1 is obsolete| | --- Comment #8 from axel <axel.amghar@gmail.com> --- Created attachment 87995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87995&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #9 from axel <axel.amghar@gmail.com> --- Created attachment 87996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87996&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #10 from axel <axel.amghar@gmail.com> --- Created attachment 87997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87997&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #11 from axel <axel.amghar@gmail.com> --- Created attachment 87998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87998&action=edit Bug 22632: Change for the research of Modules : Patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87923|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87998|0 |1 is obsolete| | --- Comment #12 from axel <axel.amghar@gmail.com> --- Created attachment 87999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87999&action=edit Bug 22632: Change for the research of Modules : Patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87998|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87995|0 |1 is obsolete| | --- Comment #13 from axel <axel.amghar@gmail.com> --- Created attachment 88043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88043&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87996|0 |1 is obsolete| | --- Comment #14 from axel <axel.amghar@gmail.com> --- Created attachment 88044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88044&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87997|0 |1 is obsolete| | --- Comment #15 from axel <axel.amghar@gmail.com> --- Created attachment 88045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88045&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel <axel.amghar@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87998|0 |1 is obsolete| | Attachment #87999|0 |1 is obsolete| | --- Comment #16 from axel <axel.amghar@gmail.com> --- Created attachment 88046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88046&action=edit Bug 22632: Change for the research of Modules : Patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |axel.amghar@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #17 from Andrew <andrew@bywatersolutions.com> --- Would it be possible for this to get entered in the log with the retained patron as the object, rather than the deleted patron? That way it would show up in the modification log for the extant patron, which seems a bit more helpful than having it tie to the deleted patron. Other than that small nitpick, this is great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #18 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Andrew from comment #17)
Would it be possible for this to get entered in the log with the retained patron as the object, rather than the deleted patron? That way it would show up in the modification log for the extant patron, which seems a bit more helpful than having it tie to the deleted patron.
Other than that small nitpick, this is great!
hi, in info we have : patron 1 has been been merged into patron 2, so we see both patrons. Did you mean to reverse the sentence in: patron 2 has been merged with patron 1 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to axel Amghar from comment #18)
(In reply to Andrew from comment #17)
Would it be possible for this to get entered in the log with the retained patron as the object, rather than the deleted patron? That way it would show up in the modification log for the extant patron, which seems a bit more helpful than having it tie to the deleted patron.
Other than that small nitpick, this is great!
hi,
in info we have : patron 1 has been been merged into patron 2, so we see both patrons.
Did you mean to reverse the sentence in: patron 2 has been merged with patron 1 ?
Hi Axel, there is an object column in the action_log table - I think he refers to that. Not to the info part. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #20 from Andrew <andrew@bywatersolutions.com> --- Hi folks, Right, as Katrin says, I'm looking at the Object column. I realize both patrons are in the Info column, so this works ok. But as it is, if I merge patrons 1 & 2, retaining patron 1, and then click Modification Log from patron 1's record the merge doesn't appear in the log search Koha generates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What Andrew suggests makes sense to me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88043|0 |1 is obsolete| | --- Comment #22 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89728&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88044|0 |1 is obsolete| | --- Comment #23 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89729&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88045|0 |1 is obsolete| | --- Comment #24 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89730&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88046|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #25 from axel Amghar <axel.amghar@biblibre.com> --- (In reply to Katrin Fischer from comment #21)
What Andrew suggests makes sense to me!
Hi, thank you for for the explanations :) I think i get it, tell me if it's better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #26 from axel Amghar <axel.amghar@biblibre.com> --- i have issues with the unit test so i put the status in assigned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89729|0 |1 is obsolete| | --- Comment #27 from axel Amghar <axel.amghar@biblibre.com> --- Created attachment 89731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89731&action=edit Bug 22632: Unit Testing of patch 22632 Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 axel Amghar <axel.amghar@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |marie-luce.laflamme@inlibro | |.com --- Comment #28 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Patch doesn't apply. The 'Merge' is not recorded in the log viewer, only the deleted account is shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sharon.dugdale@cumbria.gov. | |uk --- Comment #29 from Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> --- Hi This has come up as an issue with Cumbria Libraries and the ability to see the previous information on a merged patron record in the modification logs would be really useful. I am told that the information is retained in the deleted borrowers table however that would require a report to access the information and our frontline staff would find it very useful to be able to see these deleted personal details from the merged account. We get alot of duplicate memberships from patrons re-joining online, sometimes with more uptodate information than their existing record has and it would be useful for staff to have this information if a patron queries the merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89728|0 |1 is obsolete| | Attachment #89730|0 |1 is obsolete| | Attachment #89731|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157260&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157261&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157262&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157263&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157264&action=edit Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #35 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157265&action=edit Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- I've rebased this and added some cleanup follow-ups, but I think this still needs work to address all the QA tool issues. Hopefully someone else can take this to the finish line? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157260|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 157266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157266&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157261|0 |1 is obsolete| | --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 157267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157267&action=edit Bug 22632: adding of the rescearch of merge in the log viewer Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157262|0 |1 is obsolete| | --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 157268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157268&action=edit Bug 22632: Unit Testing of patch 22632 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157263|0 |1 is obsolete| | --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 157269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157269&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157264|0 |1 is obsolete| | --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 157270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157270&action=edit Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157265|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 157271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157271&action=edit Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #43 from David Nind <david@davidnind.com> --- I signed off before seeing comment #36 What should the status be changed to? Failed QA? Also now noted that the tests fail: prove t/db_dependent/Koha/Patron/Log.t t/db_dependent/Koha/Patron/Log.t .. 1/1 # No tests run! # Failed test 'No tests run for subtest "Test Koha::Patrons::merge"' # at t/db_dependent/Koha/Patron/Log.t line 97. Undefined subroutine &main::GetLogs called at t/db_dependent/Koha/Patron/Log.t line 44. # Looks like your test exited with 11 just after 1. t/db_dependent/Koha/Patron/Log.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patron/Log.t (Wstat: 2816 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 11 Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.11 cusr 0.26 csys = 1.39 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157278&action=edit Bug 22632: (follow-up) Tidy and fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Nind from comment #43)
I signed off before seeing comment #36
What should the status be changed to? Failed QA?
Tests should pass now, and tidied - can you confirm tests and sign off David? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #46 from David Nind <david@davidnind.com> --- (In reply to Nick Clemens from comment #45)
(In reply to David Nind from comment #43)
I signed off before seeing comment #36
What should the status be changed to? Failed QA?
Tests should pass now, and tidied - can you confirm tests and sign off David?
I'm getting a sha1 fake ancestor error when trying to apply the patches now. git bz apply 22632 Bug 22632 - Add logging of merged patrons 157266 - Bug 22632: Add logging of merged patrons 157267 - Bug 22632: adding of the rescearch of merge in the log viewer 157268 - Bug 22632: Unit Testing of patch 22632 157269 - Bug 22632: (follow-up) Use PATRON_MERGE as log action 157270 - Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm 157271 - Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t 157278 - Bug 22632: (follow-up) Tidy and fix tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22632: Add logging of merged patrons Applying: Bug 22632: adding of the rescearch of merge in the log viewer Applying: Bug 22632: Unit Testing of patch 22632 Applying: Bug 22632: (follow-up) Use PATRON_MERGE as log action Applying: Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm Applying: Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t Applying: Bug 22632: (follow-up) Tidy and fix tests error: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22632: (follow-up) Tidy and fix tests hint: Use 'git am --show-current-patch=diff' to see the failed patch ..... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157278|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157281&action=edit Bug 22632: (follow-up) Tidy and fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157281|0 |1 is obsolete| | --- Comment #48 from David Nind <david@davidnind.com> --- Created attachment 157286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157286&action=edit Bug 22632: (follow-up) Tidy and fix tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #49 from David Nind <david@davidnind.com> --- Thanks Nick! Tests now pass, signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22632: Add logging of merged patrons Applying: Bug 22632: adding of the rescearch of merge in the log viewer Applying: Bug 22632: Unit Testing of patch 22632 Applying: Bug 22632: (follow-up) Use PATRON_MERGE as log action Applying: Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm Applying: Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t Applying: Bug 22632: (follow-up) Tidy and fix tests error: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor Patch failed at 0001 Bug 22632: (follow-up) Tidy and fix tests hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22632-follow-up-Tidy-and-fix-tests-o_fvd6hr.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157266|0 |1 is obsolete| | Attachment #157267|0 |1 is obsolete| | Attachment #157268|0 |1 is obsolete| | Attachment #157269|0 |1 is obsolete| | Attachment #157270|0 |1 is obsolete| | Attachment #157271|0 |1 is obsolete| | Attachment #157286|0 |1 is obsolete| | --- Comment #51 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159553&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159554&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159555&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159556&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159557&action=edit Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159558&action=edit Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #57 from Lucas Gass <lucas@bywatersolutions.com> --- Your tests include a deleted subroutine, C4::Logs::GetLogs. You must now use Koha::ActionLogs->search instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #58 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 We'd love to have this as we are trying to restore lost data from bug 39841. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #59 from Sharon Dugdale <sharon.dugdale@cumbria.gov.uk> --- We would love to have this too please -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159553|0 |1 is obsolete| | Attachment #159554|0 |1 is obsolete| | Attachment #159555|0 |1 is obsolete| | Attachment #159556|0 |1 is obsolete| | Attachment #159557|0 |1 is obsolete| | Attachment #159558|0 |1 is obsolete| | --- Comment #60 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184493&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #61 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184494&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184495&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #63 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184496&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #64 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184497&action=edit Bug 22632: (follow-up) QA tool corrections for Log.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184493|0 |1 is obsolete| | --- Comment #65 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 184503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184503&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184494|0 |1 is obsolete| | --- Comment #66 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 184504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184504&action=edit Bug 22632: adding of the rescearch of merge in the log viewer Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184495|0 |1 is obsolete| | --- Comment #67 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 184505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184505&action=edit Bug 22632: Unit Testing of patch 22632 Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184496|0 |1 is obsolete| | --- Comment #68 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 184506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184506&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184497|0 |1 is obsolete| | --- Comment #69 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 184507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184507&action=edit Bug 22632: (follow-up) QA tool corrections for Log.t Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #70 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184503|0 |1 is obsolete| | --- Comment #71 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185058&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184504|0 |1 is obsolete| | --- Comment #72 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185059&action=edit Bug 22632: adding of the rescearch of merge in the log viewer Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184505|0 |1 is obsolete| | --- Comment #73 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185060&action=edit Bug 22632: Unit Testing of patch 22632 Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184506|0 |1 is obsolete| | --- Comment #74 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185061&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184507|0 |1 is obsolete| | --- Comment #75 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185062&action=edit Bug 22632: (follow-up) QA tool corrections for Log.t Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #76 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185063&action=edit Bug 22632: (QA follow-up) Add no warnings test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #77 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #78 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds release notes| |details of patron merges to | |the log viewer (when | |BorrowersLog is enabled). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40641 [Bug 40641] Patron.pm can create warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #79 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Tests are failing here, please follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #80 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #79)
Tests are failing here, please follow-up
I am seeing that on Koha_Master/3350 23:56:28 koha-1 | # Failed test 'GetLogs returns results in the log viewer for the merge of 526' 23:56:28 koha-1 | # at t/db_dependent/Koha/Patron/Log.t line 67. 23:56:28 koha-1 | # got: 'G7X8jre jVr_oz8M (eQXWiW9b4jX16424uC3Chn) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | # expected: 'exgnQtw lLmxQL9eWY (nHc_VZdFHIXr90p6WrIijDPgFrz8JM38) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | 23:56:28 koha-1 | # Failed test 'GetLogs returns results in the log viewer for the merge of 527' 23:56:28 koha-1 | # at t/db_dependent/Koha/Patron/Log.t line 82. 23:56:28 koha-1 | # got: 'exgnQtw lLmxQL9eWY (nHc_VZdFHIXr90p6WrIijDPgFrz8JM38) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | # expected: 'G7X8jre jVr_oz8M (eQXWiW9b4jX16424uC3Chn) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | # Looks like you failed 2 tests of 4. 23:56:28 koha-1 | 23:56:28 koha-1 | # Failed test 'Test Koha::Patrons::merge' 23:56:28 koha-1 | # at t/db_dependent/Koha/Patron/Log.t line 113. I don't recreate locally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #81 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #80)
I don't recreate locally.
% perl /kohadevbox/misc4dev/run_tests.pl --run-only t/db_dependent/Koha/Patron/Log.t It also passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #82 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186254&action=edit Bug 22632: Prevent tests to fail randomly Jenkins was failing on Koha_Master/3350 With this patch we won't rely on the order (timestamp are identical and may not be sorted as expected) 23:56:28 koha-1 | # Failed test 'GetLogs returns results in the log viewer for the merge of 526' 23:56:28 koha-1 | # at t/db_dependent/Koha/Patron/Log.t line 67. 23:56:28 koha-1 | # got: 'G7X8jre jVr_oz8M (eQXWiW9b4jX16424uC3Chn) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | # expected: 'exgnQtw lLmxQL9eWY (nHc_VZdFHIXr90p6WrIijDPgFrz8JM38) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | 23:56:28 koha-1 | # Failed test 'GetLogs returns results in the log viewer for the merge of 527' 23:56:28 koha-1 | # at t/db_dependent/Koha/Patron/Log.t line 82. 23:56:28 koha-1 | # got: 'exgnQtw lLmxQL9eWY (nHc_VZdFHIXr90p6WrIijDPgFrz8JM38) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | # expected: 'G7X8jre jVr_oz8M (eQXWiW9b4jX16424uC3Chn) has been merged into Mwqx7a zkSkFX7 (y_L7flupzFShb8JWYVCwYGSuv)' 23:56:28 koha-1 | # Looks like you failed 2 tests of 4. 23:56:28 koha-1 | 23:56:28 koha-1 | # Failed test 'Test Koha::Patrons::merge' 23:56:28 koha-1 | # at t/db_dependent/Koha/Patron/Log.t line 113. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #83 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #84 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #85 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41425 [Bug 41425] Log entries for merging patrons are untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org