[Bug 22562] New: Add ItemHoldingLibrary to ReservesControlBranch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Bug ID: 22562 Summary: Add ItemHoldingLibrary to ReservesControlBranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 86906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86906&action=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ItemHoldingLibrary to |Add option |ReservesControlBranch |ItemHoldingLibrary to | |ReservesControlBranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86906|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 100273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100273&action=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim@devinim.com.tr --- Comment #3 from Devinim <kohadevinim@devinim.com.tr> --- We have changed some conflicts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100273|0 |1 is obsolete| | --- Comment #4 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 100274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100274&action=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. Signed-off-by: Devinim <nazli@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please also change sysprefs.sql to add the option for new installations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100274|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 120617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120617&action=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Rebased on master + added required modification to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- This works, but I have an edge case: Library A - only allow holds from homelibrary Library B - allow holds form any library ReservesControlBranch: ItemsHoldingLibrary Book with homebranch Library A is checked in at Library B, a transfer is set to return the book home and the holdingbranch is set to Library B A patron from library C can place a hold because of the holdingbranch The book arrives at library A and is checked in - the hold does not trigger because the holdingbranch has changed and the rule is now 'only from home library' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Needs a rebase since Bug 30085 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 166965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166965&action=edit Bug 22562: (follow-up) fix 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Bug 30825 removes getReservesControlBranch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org