[Bug 22736] New: Search field on "New order > from suggestion" search for borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Bug ID: 22736 Summary: Search field on "New order > from suggestion" search for borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When ordering from a suggestion, the "Search" field also search the borrowernumber of the users, even if this field is not displayed in the table. It leads to have weird and non relevant results for the user. Shouldn't this search only apply to visible datas ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |17899 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Bonjour Séverine, It looks like it is the expected behaviour, from bug 17899 (commit 1104e61635e2d567c89587c28fd9a24b4f262037): - { "aTargets": [ 0 ], "bVisible": false, "bSearchable": false }, + { "aTargets": [ 0 ], "bVisible": false, "bSearchable": true }, // must be searchable for fnFilter Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17899 [Bug 17899] Show only mine does not work in newordersuggestion.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Severity|major |normal --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lowering severity. Frido, what are your thoughts on this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #2)
Lowering severity.
Frido, what are your thoughts on this?
Oh indeed, the search by borrowernumber is needed for "Show only mine" filter. I'd say the impact is really minor, close with wontfix ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #3)
(In reply to Jonathan Druart from comment #2)
Lowering severity.
Frido, what are your thoughts on this?
Oh indeed, the search by borrowernumber is needed for "Show only mine" filter.
I'd say the impact is really minor, close with wontfix ?
No, I do not think so. So answer shows us it is a bug actually :) The searchable flag for the column could be added before clicking the link, then removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Your* answer shows us it is a bug actually :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
Your* answer shows us it is a bug actually :)
Ok, but I don't know how it could be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 --- Comment #7 from Séverine Queune <severine.queune@bulac.fr> --- If it's too difficult too fix, maybe we could just display borrowernumber between parenthesis ? What bothered me was having some suggsstions displayed after a search without knowing why, because none of the displayed values matched the search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22736 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not think displaying the borrowernumber will be consistent with other views. I am sorry but I do not have anything simple to suggest. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org