[Bug 17762] New: Ability to translate notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Bug ID: 17762 Summary: Ability to translate notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org If a library has students/patrons from different countries, they will all receive the same notices. At the moment they are not translatable. An improvement would be to let the library translate the notices in different languages. This bug will get patches to achieve this goal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58133&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58134&action=edit Bug 17762: DBIC Schema changes Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58135&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58136&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58137&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58138&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58139&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58140&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58141&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17234, 17666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666 [Bug 17666] .perl atomic update does not work under kohadevbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es --- Comment #10 from Hugo Agud <hagud@orex.es> --- Hi After applying the patch I get an internal Server error and I can see this log i plack-error.log DBD::mysql::st execute failed: Unknown column 'me.lang' in 'field list' [for Statement "SELECT `me`.`borrowernumber`, `me`.`cardnumber`, `me`.`surname`, `me`.`firstname`, `me`.`title`, `me`.`othernames`, `me`.`initials`, `me`.`streetnumber`, `me`.`streettype`, `me`.`address`, `me`.`address2`, `me`.`city`, `me`.`state`, `me`.`zipcode`, `me`.`country`, `me`.`email`, `me`.`phone`, `me`.`mobile`, `me`.`fax`, `me`.`emailpro`, `me`.`phonepro`, `me`.`B_streetnumber`, `me`.`B_streettype`, `me`.`B_address`, `me`.`B_address2`, `me`.`B_city`, `me`.`B_state`, `me`.`B_zipcode`, `me`.`B_country`, `me`.`B_email`, `me`.`B_phone`, `me`.`dateofbirth`, `me`.`branchcode`, `me`.`categorycode`, `me`.`dateenrolled`, `me`.`dateexpiry`, `me`.`gonenoaddress`, `me`.`lost`, `me`.`debarred`, `me`.`debarredcomment`, `me`.`contactname`, `me`.`contactfirstname`, `me`.`contacttitle`, `me`.`guarantorid`, `me`.`borrowernotes`, `me`.`relationship`, `me`.`sex`, `me`.`password`, `me`.`flags`, `me`.`userid`, `me`.`opacnote`, `me`.`contactnote`, `me`.`sort1`, `me`.`sort2`, `me`.`altcontactfirstname`, `me`.`altcontactsurname`, `me`.`altcontactaddress1`, `me`.`altcontactaddress2`, `me`.`altcontactaddress3`, `me`.`altcontactstate`, `me`.`altcontactzipcode`, `me`.`altcontactcountry`, `me`.`altcontactphone`, `me`.`smsalertnumber`, `me`.`sms_provider_id`, `me`.`privacy`, `me`.`privacy_guarantor_checkouts`, `me`.`checkprevcheckout`, `me`.`updated_on`, `me`.`lastseen`, `me`.`lang` FROM `borrowers` `me` WHERE ( `userid` = ? )" with ParamValues: 0='Odigital'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.lang' in 'field list' at /home/vagrant/kohaclone/Koha/Objects.pm line 176 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Hugo Agud from comment #10)
After applying the patch I get an internal Server error and I can see this log i plack-error.log
Hi Hugo, You need to apply patches from bug 17234 (not the 3.14 patch) and bug 17666. Then you have to execute the updatedatabase script (`perl installer/data/mysql/updatedatabase.pl`) to update the DB structure. Then restart plack and everything should go fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3150 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #12 from Hugo Agud <hagud@orex.es> --- I have installed the patch and I have been able to test with PREDUE and ODUE and it almost works fine. I am able to receive the letter in the prefered language, BUT if I change the prefered language it has no effect on the letter language I have restarted memcached, plack and the kohadevbox with no effect on the language lettter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Hugo Agud from comment #12) Hi Hugo, thanks for testing!
I am able to receive the letter in the prefered language, BUT if I change the prefered language it has no effect on the letter language
Can you detail the different steps you made? You should not need to restart plack or memcached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #14 from Hugo Agud <hagud@orex.es> --- Thanks to you.. I have applied your test plan and then change the language preference for notices and start again Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Once I finished this with success, I decided to change the 'Preferred language for notices' to ca-ES and I have tested in different ways 1. Execute again the cron scripts for advance and overdue, it generate the letter in the firs language I seleted (es-ES) 2. I checked-in and checked-out again the books, and execute again the cron scripts overudue and advance notice and the letters still in (es-ES) instead of the new (ca-ES) I have restarted memcached and plack and the server just in case.. I hope it helps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58525&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Hugo Agud <hagud@orex.es> --- checked and working fine! Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Jonathan, could you add followup due to bug 16239? Updated wiki page for reference: https://wiki.koha-community.org/wiki/Interface_patterns Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Ah, looks like it probably will need rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58133|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59452&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58134|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59453&action=edit Bug 17762: DBIC Schema changes Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58135|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59454&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58136|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59455&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58137|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59456&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58138|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59457&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58139|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59458&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58140|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59459&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58141|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59460&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58525|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59461&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Jonathan, I like the idea and how it is implemented. My only doubt is about the existence of the 'default' tab. I expected 'default' to be a given language, not a different one than (say) Ensligh. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's default in the sense that it will fallback to this notice if the one we want is not defined. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59452|0 |1 is obsolete| | Attachment #59453|0 |1 is obsolete| | Attachment #59454|0 |1 is obsolete| | Attachment #59455|0 |1 is obsolete| | Attachment #59456|0 |1 is obsolete| | Attachment #59457|0 |1 is obsolete| | Attachment #59458|0 |1 is obsolete| | Attachment #59459|0 |1 is obsolete| | Attachment #59460|0 |1 is obsolete| | Attachment #59461|0 |1 is obsolete| | --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61614&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61615&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61616&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61617&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61618&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61619&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61620&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61621&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61622&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only Signed-off-by: Hugo Agud <hagud@orex.es> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61623&action=edit Bug 17762: Fix test for NewsChannels.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61624&action=edit Bug 17762: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Rebased and fixed a test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61614|0 |1 is obsolete| | Attachment #61615|0 |1 is obsolete| | Attachment #61616|0 |1 is obsolete| | Attachment #61617|0 |1 is obsolete| | Attachment #61618|0 |1 is obsolete| | Attachment #61619|0 |1 is obsolete| | Attachment #61620|0 |1 is obsolete| | Attachment #61621|0 |1 is obsolete| | Attachment #61622|0 |1 is obsolete| | Attachment #61623|0 |1 is obsolete| | Attachment #61624|0 |1 is obsolete| | --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63199&action=edit Bug 17762: DB changes - Add new 'lang' columns to letter and borrowers tables Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63200&action=edit Bug 17762: Add the new TranslateNotices syspref This whole patch set adds the ability to translate notices in different languages. That way, if a library has patrons from different countries, they will not have to send the notices in only one language but they will be able to translate them. Test plan: - Switch on TranslateNotices - Translate the interface in different languages - Edit patron's details => You should see a new "prefered language" entry That language will be used to send notices to this patron - Edit several notice templates => You should see different tabs, 1 tab per language translated at the opac (which sounds to make sense) - Now the notice generated for this patron should be the one translated in the language picked for him To confirm that, try to generate several notices for this patron. If the notice is not translated, the default one should be used. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63201&action=edit Bug 17762: Add the lang attribute to the patron form Not the opac because we do not want the patron to modify it, they won't be necessary translated. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63202&action=edit Bug 17762: Remove FK on message_transports I don't really understand where does come from this foreign key but at first glance it does not make sense. Note that it seems we could also remove message_transports.branchcode Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63203&action=edit Bug 17762: Add lang to the PK of letter We need to enlarge the PK of the letter table. Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63204&action=edit Bug 17762: Update the letter form interface If the pref is on, the notice template will be translatable in different languages Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63205&action=edit Bug 17762: Send lang to GetPreparedLetter This patch set the lang parameter when C4::Letters::GetPreparedLetter is called to generate the notice. Note that we do not need to pass it if want_librarian is set. TODO: I do not know what to do with TransferSlip Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63206&action=edit Bug 17762: Add the lang parameter to C4::Letters::getletter Sponsored-by: Orex Digital Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63207&action=edit Bug 17762: Fix sql fields insertion The "Insert ->" buttons used to copy the sql field to the textarea was based on the id of the fieldset. This id has to be unique to work as expected. It is now composed of mtt + lang instead of mtt only Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63208&action=edit Bug 17762: Fix test for NewsChannels.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63209&action=edit Bug 17762: DBIC Schema changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63210&action=edit Bug 17762 (QA Followup) Use default lang if pref disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63211&action=edit Bug 17762 (QA Followup) Fix Letters.t - add lang to fixtures -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- All looks good, I added a followup so that we don't send translated notices if the pref is off. One question, you have: a/members/moremember.pl 335 # Display the language description instead of the code 336 # Note that this is certainly wrong It seems to work, why is it wrong? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 --- Comment #57 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #56)
All looks good, I added a followup so that we don't send translated notices if the pref is off.
One question, you have: a/members/moremember.pl 335 # Display the language description instead of the code 336 # Note that this is certainly wrong
It seems to work, why is it wrong?
I think we should display the description in the translated language. For instance "Spanish" is always "Español", whatever the language of the interface (same as the language list in the footer). It sounds wrong to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Very much looking forward to this! This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Bug 17762 depends on bug 17234, which changed state. Bug 17234 Summary: ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This develop adds the release notes| |ability to translate | |notices in different | |languages. That way, if a | |library has patrons from | |different countries, they | |will not have to send the | |notices in only one | |language but they will be | |able to translate them. | |In | |patron's details page you | |can see a new "prefered | |language" entry, you select | |a language to use it in | |letters. CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This develop adds the |It's now possible to release notes|ability to translate |translate notice templates |notices in different |into different languages. |languages. That way, if a |There is a new 'preferred |library has patrons from |language' setting available |different countries, they |in the user account, that |will not have to send the |controls which template |notices in only one |will be used when |language but they will be |generating notices. |able to translate them. | |In | |patron's details page you | |can see a new "prefered | |language" entry, you select | |a language to use it in | |letters. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18664 [Bug 18664] IssueSlip.t is failing - IssueSlip should return if params are not valid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal@gmail.com --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 7224 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18911 [Bug 18911] Option to set preferred language in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18911 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18911 [Bug 18911] Option to set preferred language in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18911 [Bug 18911] Option to set preferred language in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19344 [Bug 19344] DB fields login_attempts and lang may be inverted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19675 [Bug 19675] Cannot save notices when setting the TranslateNotices preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21571 [Bug 21571] Translate notices fail on ACCTDETAILS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 17160 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17762 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26420 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org