[Bug 31992] New: t::lib::Mocks::Zebra still using old stage for import page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Bug ID: 31992 Summary: t::lib::Mocks::Zebra still using old stage for import page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 27421 This has been forgotten by bug 27421. And there is a ref to background-job-progress.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142674&action=edit Bug 31992: Fix t::lib::Mocks::Zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's not working, I think I am missing a step in the import. I need to leave for today, so letting this patch here, in case someone wants to give it a try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142674|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142675&action=edit Bug 31992: Fix t::lib::Mocks::Zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142675|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 142695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142695&action=edit Bug 31992: Fix t::lib::Mocks::Zebra This will fix t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t QA - improvement ideas welcome! It's definitely not the best we can do. Test plan: prove t/db_dependent/www/search_utf8.t t/db_dependent/www/batch.t must return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- Getting a sha1 error when applying th epatch: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31992: Fix t::lib::Mocks::Zebra error: sha1 information is lacking or useless (t/db_dependent/www/batch.t). error: could not build fake ancestor Patch failed at 0001 Bug 31992: Fix t::lib::Mocks::Zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #5)
Getting a sha1 error when applying th epatch:
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31992: Fix t::lib::Mocks::Zebra error: sha1 information is lacking or useless (t/db_dependent/www/batch.t). error: could not build fake ancestor Patch failed at 0001 Bug 31992: Fix t::lib::Mocks::Zebra
It needs the last 2 follow-ups from bug 31162. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #6)
(In reply to David Nind from comment #5)
Getting a sha1 error when applying th epatch:
Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31992: Fix t::lib::Mocks::Zebra error: sha1 information is lacking or useless (t/db_dependent/www/batch.t). error: could not build fake ancestor Patch failed at 0001 Bug 31992: Fix t::lib::Mocks::Zebra
It needs the last 2 follow-ups from bug 31162.
Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 --- Comment #8 from David Nind <david@davidnind.com> --- Tests are failing for me: prove -v t/db_dependent/www/search_utf8.t t/db_dependent/www/search_utf8.t .. 1..0 # SKIP Tests skip. You must set env. variable KOHA_INTRANET_URL to do tests Can't call method "cleanup" on an undefined value at t/db_dependent/www/search_utf8.t line 188. END failed--call queue aborted. # Looks like your test exited with 22 before it could output anything. skipped: Tests skip. You must set env. variable KOHA_INTRANET_URL to do tests Test Summary Report ------------------- t/db_dependent/www/search_utf8.t (Wstat: 5632 Tests: 0 Failed: 0) Non-zero exit status: 22 Files=1, Tests=0, 1 wallclock secs ( 0.03 usr 0.00 sys + 1.03 cusr 0.08 csys = 1.14 CPU) Result: FAIL prove -v t/db_dependent/www/batch.t t/db_dependent/www/batch.t .. Warning: <retrieval> element has non-unique value in 'name' key attribute: F at t/db_dependent/www/batch.t line 35. Warning: <retrieval> element has non-unique value in 'name' key attribute: B at t/db_dependent/www/batch.t line 35. 1..24 Error GETing /cgi-bin/koha/mainpage.pl: URL must be absolute at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 131. # Looks like your test exited with 255 before it could output anything. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 24/24 subtests Test Summary Report ------------------- t/db_dependent/www/batch.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 24 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.15 cusr 0.07 csys = 1.25 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142695|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142745&action=edit Bug 31992: Fix t::lib::Mocks::Zebra This will fix t/db_dependent/www/batch.t and t/db_dependent/www/search_utf8.t QA - improvement ideas welcome! It's definitely not the best we can do. Test plan: prove t/db_dependent/www/search_utf8.t t/db_dependent/www/batch.t must return green Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I had to reset_all on ktd before these tests would pass.. but that's not unreasonable.. I think I had some cleanup issues before testing. It took a little while to wrap my head around the changes, but they do make sense. I couldn't come up with a nicer way to do the sleep either :(/ Signing off and will continue to ponder if there are improvements to be made.. one to keep refining I think, but I'd be tempted to push what we have to clear the wood for the tree's to spot other failing tests down the line before release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #8) Try in a koha-shell, it will set KOHA_INTRANET_URL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jonathan Druart from comment #11)
(In reply to David Nind from comment #8)
Try in a koha-shell, it will set KOHA_INTRANET_URL.
Same issue, thanks a lot. That's a precious info, I got to document this for RMaints also. When running test locally, me Fridolin and Kyle always had some test failing. Most were the www ones. So finally we know the cause and the fix, thanks again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142745|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Bug 31992 depends on bug 31162, which changed state. Bug 31162 Summary: Add a clear cataloguing module home page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31992 Bug 31992 depends on bug 27421, which changed state. Bug 27421 Summary: Porting tools/stage-marc-import.pl to BackgroundJob https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org