[Bug 16151] New: can't place holds from lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Bug ID: 16151 Summary: can't place holds from lists Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 14544 Looks like https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 might have broken the ability to place holds from lists. * selected the public list * placed a check next to the first and fourth items on the list at the top of the list, I selected 'Place Hold' * Got the following error message: Can't call method "field" on an undefined value at /home/load17/kohaclone/C4/Items.pm line 1491. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 [Bug 14544] Move the list related code to Koha::Virtualshelves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49620&action=edit Bug 16151: Restore the ability to place holds from lists at the OPAC This patch fixes a bug introduced by bug 14544. Holds can not be placed from lists at the OPAC, the action results in a crash: Can't call method "field" on an undefined value at /home/koha/src/C4/Items.pm line 1504. at /home/koha/src/opac/opac-reserve.pl line 601 Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like REM-4242. Now we can retrieve the biblionumber from the value. Test plan: Select a public list check some titles and click on the 'Place hold' link you should able to process the reservation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|3.22 |master --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We want to see this fixes pushed to the next 3.22 release. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49620|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 49623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49623&action=edit Bug 16151: Restore the ability to place holds from lists at the OPAC This patch fixes a bug introduced by bug 14544. Holds can not be placed from lists at the OPAC, the action results in a crash: Can't call method "field" on an undefined value at /home/koha/src/C4/Items.pm line 1504. at /home/koha/src/opac/opac-reserve.pl line 601 Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like REM-4242. Now we can retrieve the biblionumber from the value. Test plan: Select a public list check some titles and click on the 'Place hold' link you should able to process the reservation Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49623|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49646&action=edit Bug 16151: Restore the ability to place holds from lists at the OPAC This patch fixes a bug introduced by bug 14544. Holds can not be placed from lists at the OPAC, the action results in a crash: Can't call method "field" on an undefined value at /home/koha/src/C4/Items.pm line 1504. at /home/koha/src/opac/opac-reserve.pl line 601 Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like REM-4242. Now we can retrieve the biblionumber from the value. Test plan: Select a public list check some titles and click on the 'Place hold' link you should able to process the reservation Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16151 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org