[Bug 27090] New: In the location column of an Opac basket the 'In transit from' and 'to' fields are empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Bug ID: 27090 Summary: In the location column of an Opac basket the 'In transit from' and 'to' fields are empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org When you have an item in transfer and if it is in an Opac basket, in the location column the 'In transit from' and 'to' fields are empty. It is due to the lack in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc of [% USE Branches %]. I will propose a patch. thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |christophe.croullebois@bibl | |ibre.com Assignee|oleonard@myacpl.org |christophe.croullebois@bibl | |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 113971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113971&action=edit in an Opac basket enables the 'In transit from' and 'to' fields to be displayed To see the 'In transit from' and 'to' fields in an Opac basket we have : <span class="item-status intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span> But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 --- Comment #2 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- To test : 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Thx -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114708&action=edit Bug 26051: Elasticsearch field local-classification sort=1 in mapping.yaml With Elasticsearch the search field use for sorting by callnumber is "local-classification" (from Koha::SearchEngine::Elasticsearch::QueryBuilder::_convert_sort_fields). So this search field must be sortable in default mappings.yaml. If not you see this error in logs : No mapping found for [local-classification__sort] Test plan : 1) Install Koha with Elasticsearch with mappings.yaml from sources (admin/searchengine/elasticsearch/mappings.yaml) It should be the case on all developement instalations 2) Reset mappings (Administration › Search engine configuration (Elasticsearch)) 3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -d 4) Perform a search 5) Check sorting by callnumber is OK (add some call numbers if necessary) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114709&action=edit Bug 27090: Opac basket: fix the 'In transit from' and 'to' To see the 'In transit from' and 'to' fields in an Opac basket we have : <span class="item-status intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span> But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Test plan: 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Attachment #114708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Oops, attached an additional patch that was from another ticket. Thanks, it works as expected :) Fixed the commit message to include the description of the fix and test plan. (I just copied comment 1 and comment 2) And made the first line of the commit message shorter to be in git recommendations (70 chars max) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114709|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114967&action=edit Bug 27090: Opac basket: fix the 'In transit from' and 'to' To see the 'In transit from' and 'to' fields in an Opac basket we have : <span class="item-status intransit">In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %]</span> But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Test plan: 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In the location column of |In the location column of |an Opac basket the 'In |an OPAC cart the 'In |transit from' and 'to' |transit from' and 'to' |fields are empty |fields are empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.02 |21.05.00,20.11.02,20.05.08 released in| | CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.02,20.05.08 |21.05.00,20.11.02,20.05.08, released in| |19.11.14 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 19.11.x branch for 19.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org