[Bug 18046] New: Problem with redirect on logout with CAS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Bug ID: 18046 Summary: Problem with redirect on logout with CAS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Since updating to 3.22.14 which includes the fix for bug 17841, there is a problem when logging out of the OPAC with CAS. Settings: casLogout = Logout Before the update, you weren't redirected back to the OPAC after logout. Bug 17841 was supposed to fix this behaviour. After the update, we are sending the redirect URL in the service parameter of the logout URL: https://.../logout?url=https%3A%2F%2F...%2Fcgi-bin%2Fkoha%2Fopac-main.pl%3Fl... The CAS logout itself works, but the redirect to Koha seems to be stuck in an "infinite loop". The page reloads again and again. It seems to work ok, when you craft an URL like: https://.../logout?url=https%3A%2F%2F...%2Fcgi-bin%2Fkoha%2Fopac-main.pl%3Fl... without the logout.x%3D1 parameter at the end of the URL. Tested in Firefox ESR 45.7.0. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17481 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, had the wrong bug number: bug 17481 was the change that changed things... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 [Bug 17481] Cas Logout: bug 11048 has been incorrectly merged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Upping severity a bit as this is a problem for end users in the OPAC and it looks like Koha is killing the browser. We fixed it temporarily by removing the logout.x=1 from the URL used for redirecting on logout: sub logout_cas { my ($query, $type) = @_; my ( $cas, $uri ) = _get_cas_and_service($query, undef, $type); + $uri =~ s/\?logout\.x=1//; print $query->redirect( $cas->logout_url(url => $uri)); } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Ah yes, because opac-main.pl looks for the existence of the logout param it will just log them out again and again and again. So your fix is the right fix. I will attach a patch here soon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 66254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66254&action=edit Bug 18046 CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66254|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66282&action=edit [SIGNED OFF] Bug 18046 CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Patch has been in production use for several months on several instances. Fixes a critical bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |chris@bigballofwax.co.nz QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66282|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 66456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66456&action=edit Bug 18046 CAS logout infinite redirect To test (You need a CAS server and CAS configured in Koha) 1/ Login using CAS in Koha 2/ Logout in Koha 3/ Notice you get redirected again and again 4/ Apply patch 5/ Login with CAS, then logout 6/ Notice logout works, but no longer infinitely redirected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Patch has been in production use for several months on several instances. Fixes a critical bug. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks like a typical workaround, but evidently works. Not tested with CAS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org