[Bug 17368] New: plugins tests are broken - KitchenSinkPlugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Bug ID: 17368 Summary: plugins tests are broken - KitchenSinkPlugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 [Bug 7804] Add Koha Plugin System -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55888&action=edit Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55888|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 56287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56287&action=edit Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Signed-off-by: Magnus Enger <magnus@libriotech.no> prove t/db_dependent/Plugins.t fails before the patch and passes nicely after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56287|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 56690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56690&action=edit Bug 17368: Update KitchenSinkPlugin.kpz The KitchenSinkPlugin plugin is used is t/db_dependent/plugins.t to test if our system plugin is ok. Currently this plugin is broken because it uses subroutines which have been removed: GetBranchesLoop and GetBorrowercategoryList A PR has just been made (https://github.com/bywatersolutions/koha-plugin-kitchen-sink/pull/2) This kpz has been generated on top of the following commit: commit 5d109c9e1a5d3d314b346a529f2059176778d05a Adapt code for versions > 16.06.00.018 2 subroutines has been removed and the plugin does not work anymore. with: % zip -r KitchenSinkPlugin.kpz Koha Test plan: prove t/db_dependent/plugins.t should now be happy Signed-off-by: Magnus Enger <magnus@libriotech.no> prove t/db_dependent/Plugins.t fails before the patch and passes nicely after applying the patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Version|unspecified |master CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17368 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org