[Bug 16674] New: remove two broken test from t/Ris.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Bug ID: 16674 Summary: remove two broken test from t/Ris.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: gmcharlt@gmail.com QA Contact: gmcharlt@gmail.com The patch for bug 16442 happened to change the implicit return values for C4::Ris::print_title() and C4::Ris::print_stitle(), thereby breaking two tests t/Ris.t. However... on reflection those two tests are not very useful, as they test the return value of two routines that neither advertise nor supply any return value: their sole purpose is to calculate some values and print them to STDOUT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 52108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52108&action=edit Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16668 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52108|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52198&action=edit [SIGNED-OFF]Bug 16674: remove two tests from t/Ris.t This patch removes two tests that were broken by the patch for bug 16442, thus preventing packages from being build in master. Ordinarily, one would either fix the tests or change the code that broke the tests... but as the tests in question check the return value of routines that do not actually advertise a return value, I've elected to simply remove them. To test ------- [1] Verify that t/Ris.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |RESOLVED --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 16668 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org