[Bug 8413] New: Space in barcode breaks GET request in benchmark_staff.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Priority: P5 - low Change sponsored?: --- Bug ID: 8413 Assignee: 5p4m@gmx.de Summary: Space in barcode breaks GET request in benchmark_staff.pl Severity: normal Classification: Unclassified OS: All Reporter: 5p4m@gmx.de Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. The bug led to really nice plack benchmarks. Unfortunately they were not true. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 --- Comment #1 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10759&action=edit Bug 8413 Space in call number breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 --- Comment #2 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10760&action=edit Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mjr@software.coop --- Comment #3 from MJ Ray (software.coop) <mjr@software.coop> --- Could you use URI::Escape::uri_escape_utf8 instead of regexing, please? Koha already depends on URI::Escape so that would not introduce a new requirement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 --- Comment #4 from Mirko Tietgen <5p4m@gmx.de> --- Created attachment 10765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10765&action=edit [PATCH] Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. Also fixes a typo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Mirko Tietgen <5p4m@gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10765|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11397&action=edit Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl GET requests in benchmark_staff.pl test 6 do not work if a space character is part of the barcode. That seems highly unlikely to happen in barcodes, but is possible if no real barcodes are used but a substitute, like a copy of the call number. Space character needs to be changed to %20 for the request to work. Also fixes a typo. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
Created attachment 11397 [details] Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
trivial patch, passing QA mason@xen1:~/git/head$ koha-qa.pl * 363e671 Bug 8413 Space in barcodes breaks GET request in benchmark_staff.pl misc/load_testing/benchmark_staff.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- In 3.8.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org