[Bug 34036] New: Single receive doesn't reload data and order lines appears as pending
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Bug ID: 34036 Summary: Single receive doesn't reload data and order lines appears as pending Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 8179 When you receive a single order line using the Receive link, the table appears with the order line still pending instead of it showing in the "Already received" section. When you manually reload the table, the order line moves. To test: * Create a basket and order line, close basket. * Receive shipment, create invoice. * Click on the receive link in the table of pending order lines. * Fill out the form, especially the quantity received. Save. * Verify the line still shows in the "pending orders" table, instead of the "Already received" area below. * Reload page, order line now moves. I believe we need to reload some data? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|enhancement |normal Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I just tested this again and it looks like the "Pending orders" table reloads, updating the Quantity if you do a partial receive, but the "Already received" table is not updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like the "Already received" is not yet API driven, but in this case we need to force a page reload maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... or make it API driven, but that's the harder fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Single receive doesn't |Single receive doesn't |reload data and order lines |reload data and order lines |appears as pending |don't appear in received | |section -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 34595 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #5 from wainuiwitikapark@catalyst.net.nz --- (In reply to Katrin Fischer from comment #2)
It looks like the "Already received" is not yet API driven, but in this case we need to force a page reload maybe?
I think this might be the best way to do it now yeah -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on|8179 |33784 Status|ASSIGNED |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33784 [Bug 33784] Save clicks on single order receive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 155049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155049&action=edit Bug 34036: Reload 'already received' table when edit modal closed Bug 33784 introduced a fix that prevents the 'already received' table from reloading completely if the modal is hidden and there is only one order in the table. This appears to assume that the 'hidden modal' event is only triggered if the receive form is cancelled, but the 'hidden modal' event is also triggered when the receive form is submitted. This means that the table isn't redrawn when the form is submitted and there's one order already received, so the next order does not show in the table when the page reloads. To test: 1. Set up a vendor, budget, fund, and create a new basket. 2. Add two orders (two different records) to this basket. 3. Close the basket and go to receive the orders. 4. Once on the 'Receive orders' page, use the checkboxes in the Pending orders table to receive both orders at once. Choose the 'Receive selected' button 5. Click Edit for the first order, receive the item and click 'Next order'. Receive the next item and click 'Save changes'. Then Confirm 6. Both orders should now show under Already received. Click Cancel receipt for one of the orders. It should go back to Pending orders. 7. Click Receive for the now pending order. Receive the item and Confirm. 8. Notice that the page appears to reload but the order doesn't show under Already received with the other order. The order also no longer shows under Pending orders. 9. Apply the patch and restart services. Reload the page. Cancel receipt of the order again. 10. Click Receive for the now pending order. Receive the item and Confirm. 11. The Already received table should reload so that both orders now show under Already received. 12. Click Cancel receipt for the order. 13. Click Receive for the now pending order, then Cancel without receiving the item. 14. Confirm the page loads as expected with one pending order and one already received order. Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored Assignee|wainuiwitikapark@catalyst.n |aleisha@catalyst.net.nz |et.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155049|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 155058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155058&action=edit Bug 34036: Reload 'already received' table when edit modal closed Bug 33784 introduced a fix that prevents the 'already received' table from reloading completely if the modal is hidden and there is only one order in the table. This appears to assume that the 'hidden modal' event is only triggered if the receive form is cancelled, but the 'hidden modal' event is also triggered when the receive form is submitted. This means that the table isn't redrawn when the form is submitted and there's one order already received, so the next order does not show in the table when the page reloads. To test: 1. Set up a vendor, budget, fund, and create a new basket. 2. Add two orders (two different records) to this basket. 3. Close the basket and go to receive the orders. 4. Once on the 'Receive orders' page, use the checkboxes in the Pending orders table to receive both orders at once. Choose the 'Receive selected' button 5. Click Edit for the first order, receive the item and click 'Next order'. Receive the next item and click 'Save changes'. Then Confirm 6. Both orders should now show under Already received. Click Cancel receipt for one of the orders. It should go back to Pending orders. 7. Click Receive for the now pending order. Receive the item and Confirm. 8. Notice that the page appears to reload but the order doesn't show under Already received with the other order. The order also no longer shows under Pending orders. 9. Apply the patch and restart services. Reload the page. Cancel receipt of the order again. 10. Click Receive for the now pending order. Receive the item and Confirm. 11. The Already received table should reload so that both orders now show under Already received. 12. Click Cancel receipt for the order. 13. Click Receive for the now pending order, then Cancel without receiving the item. 14. Confirm the page loads as expected with one pending order and one already received order. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155058|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 155273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155273&action=edit Bug 34036: Reload 'already received' table when edit modal closed Bug 33784 introduced a fix that prevents the 'already received' table from reloading completely if the modal is hidden and there is only one order in the table. This appears to assume that the 'hidden modal' event is only triggered if the receive form is cancelled, but the 'hidden modal' event is also triggered when the receive form is submitted. This means that the table isn't redrawn when the form is submitted and there's one order already received, so the next order does not show in the table when the page reloads. To test: 1. Set up a vendor, budget, fund, and create a new basket. 2. Add two orders (two different records) to this basket. 3. Close the basket and go to receive the orders. 4. Once on the 'Receive orders' page, use the checkboxes in the Pending orders table to receive both orders at once. Choose the 'Receive selected' button 5. Click Edit for the first order, receive the item and click 'Next order'. Receive the next item and click 'Save changes'. Then Confirm 6. Both orders should now show under Already received. Click Cancel receipt for one of the orders. It should go back to Pending orders. 7. Click Receive for the now pending order. Receive the item and Confirm. 8. Notice that the page appears to reload but the order doesn't show under Already received with the other order. The order also no longer shows under Pending orders. 9. Apply the patch and restart services. Reload the page. Cancel receipt of the order again. 10. Click Receive for the now pending order. Receive the item and Confirm. 11. The Already received table should reload so that both orders now show under Already received. 12. Click Cancel receipt for the order. 13. Click Receive for the now pending order, then Cancel without receiving the item. 14. Confirm the page loads as expected with one pending order and one already received order. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Missing dependencies in 22.11.x - not backporting Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org