[Bug 32803] New: EnableItemGroups and EnableItemGroupHolds options are wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Bug ID: 32803 Summary: EnableItemGroups and EnableItemGroupHolds options are wrong Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com I played around with item groups and now in my About page > System information, I have an error message System preference 'EnableItemGroups' must be '0' or '1', but is 'no'. System preference 'EnableItemGroupHolds' must be '0' or '1', but is 'no'. I think it may be the options in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref that are yes/no, but should be 1/0? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- The installer data (installer/data/mysql/mandatory/sysprefs.sql) and dbrevs (installer/data/mysql/db_revs/220600014.pl and installer/data/mysql/db_revs/220600078.pl) insert 0 for both by default. So I think that part is OK. It's only when you change them manually in the interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146022&action=edit Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Depends on| |24857, 24860 Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 [Bug 24857] Add ability to group items for records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 [Bug 24860] Add ability to place item group level holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146022|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146263&action=edit Bug 32803 - EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146263|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147209&action=edit Bug 32803: EnableItemGroups and EnableItemGroupHolds options are wrong This patch corrects the options for the EnableItemGroups and EnableItemGroupHolds system preferences. To test: 1. Enable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Enable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 2. Go to About Koha > System information --> There is a warning message 3. Go to a bibliographic record with at least one item --> The item group tab is displayed 4. Create an item group 4.1. Click New item group 4.2. Enter a name 4.3. Click Submit 4.4. In the Holdings tab, select the item 4.5. Click on Add/move to item group 4.6. Click Set item group 5. Place a hold on the item group 5.1. Click Place hold 5.2. Search for a patron 5.3. In the 'Hold next available item from an item group' section, select the item group 5.4. Click Place hold --> Placing a hold is possible 6. Disable EnableItemGroups and EnableItemGroupHolds system preferences 1.1. Go to Administration > Global system preferences 1.2. Search for EnableItemGroup (no s, to get both) 1.3. Disable both EnableItemGroups and EnableItemGroupHolds 1.4. Click Save all Circulation preferences 7. Go to About Koha > System information --> There is a warning message 8. Apply patch 9. Redo steps 1 and 2 --> There is no warning 10. Redo step 3 --> The item group tab is displayed 11. Redo steps 4 and 5 --> Placing a hold is possible 12. Redo steps 6 and 7 --> There is no warning Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> JD Amended commit message: * Commit title does not start with 'Bug XXXXX: ' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |jonathan.druart+koha@gmail. |y.org |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org