[Bug 19957] New: Allow continued editing after saving a report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Bug ID: 19957 Summary: Allow continued editing after saving a report Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70439&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 9 - Note errors stil display as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70443&action=edit Bug 19957 - Hide saved message once editing report To test: 1 - Apply this patch 2 - Save/Update report 3 - Note when you focus on the 'sql' area the saved message dissappears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I don't think it's necessary to show all the links from the old confirmation page. They're all in the toolbar or the sidebar. I would prefer that we instead put a standard "message" type dialog saying "Your report has been saved." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70439|0 |1 is obsolete| | Attachment #70443|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70604&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report11 - Verify message works on update of existing report and save of new report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70604|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70605&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- The message dialog should replace "<div class="alert alert-info">" ...with... <div class="dialog message"> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70605|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70767&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70767|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70769&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70769|0 |1 is obsolete| | --- Comment #9 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 70776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70776&action=edit Bug 19957 - Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com --- Comment #10 from Charles Farmer <charles.farmer@inlibro.com> --- Passes qa1. Works as advertised: I was sent back to editing the form after a modification, and the behaviour of the controller when saving an erroneous SQL is kept as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At first I was a little irritated, but as the toolbar gives you all the options here, I think the returning to the edit form works for this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70776|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73242&action=edit Bug 19957: Allow continued editing of report after saving To test: 1 - Edit or create a report 2 - Save it 3 - Note the report is saved but you can't keep editing 4 - Clicking 'Edit' returns you to editing 5 - Apply patch 6 - Save report 7 - Note success message remains, but report is still open for editing 8 - Note when you click the saved/updated message dissappears 9 - Try again after inserting erros into report (No Select, bad authorised value, etc.) 10 - Note errors stil display as expected 11 - Verify message works on update of existing report and save of new new report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Current patch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22278 [Bug 22278] Newly created report group is not selected after saving an SQL report -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org