http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3527 Summary: writeoff doesn't handle locally-defined manual invoice types well Product: Koha Version: HEAD Platform: All OS/Version: Linux - Debian Status: NEW Severity: normal Priority: PATCH-Sent Component: Patrons AssignedTo: dbavousett@ptfs.com ReportedBy: dbavousett@ptfs.com Estimated Hours: 0.25 Change sponsored?: --- In sub writeoff in members/pay.pl, there is a long WHERE clause looking for a long list of legacy accounttypes. This prevents writeoff of any locally-defined ones. Furthermore, this clause is un-needed, as the only calls to this subroutine will already be for positive-value amountoutstanding, since that's what pay.pl will be displaying to the user, and we already have the accountnum and borrowernum. Patch will be on the way momentarily, but here is the diff: diff --git a/members/pay.pl b/members/pay.pl --- a/members/pay.pl +++ b/members/pay.pl @@ -199,7 +199,7 @@ sub writeoff { undef $itemnum unless $itemnum; # if no item is attached to fine, make sure to store it as a NULL my $sth = $dbh->prepare( -"Update accountlines set amountoutstanding=0 where (accounttype='Res' OR accounttype='FU' OR accounttype ='IP' OR accounttype='CH' OR accounttype='N' OR accounttype='F +"Update accountlines set amountoutstanding=0 where accountno=? and borrowernumber=?" ); $sth->execute( $accountnum, $borrowernumber ); $sth->finish; -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.