[Bug 29795] New: if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Bug ID: 29795 Summary: if branchcode is included in PatronSelfRegistrationBorrowerMandatoryField it should default to an empty value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate; 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 129016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129016&action=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Creates an empty value and release notes| |defaults to it when | |PatronSelfRegistrationBorro | |werMandatoryField includes | |branchcode. This forces | |self registering users to | |make a choice for | |branchcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129016|0 |1 is obsolete| | --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 130236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130236&action=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|if branchcode is included |If branch is mandatory on |in |patron self registration |PatronSelfRegistrationBorro |form, the pull down should |werMandatoryField it should |default to empty |default to an empty value | Text to go in the|Creates an empty value and |Creates an empty value and release notes|defaults to it when |defaults to it when |PatronSelfRegistrationBorro |PatronSelfRegistrationBorro |werMandatoryField includes |werMandatoryField includes |branchcode. This forces |branchcode. This forces |self registering users to |self registering users to |make a choice for |make a choice for the |branchcode. |library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130236|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130542&action=edit Bug 29795: add empty value for branchcode on self-reg form 1. Set branch code as a PatronSelfRegistrationBorrowerMandatoryField 2. Go to the self reg form and look at the Home library field, it defaults to the first choice alphabetically 3. Fill out the other required fields and the captcha. Don't change the branchcode value. 4. Submit the form, it submits. 5. If branchcode is required it should default to an empty value and force the user to make a choice. 6. Apply patch 7. Repeat 1-3 8. Now you cannot submit the form unless you choose a branchcode 9. Make sure it still works normally when branchcode is not in PatronSelfRegistrationBorrowerMandatoryField Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Makes sens. But why not adding this empty value when branchcode is not mandatory ? Is selecting first in list a way to have a default library ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #5)
Makes sens.
But why not adding this empty value when branchcode is not mandatory ? Is selecting first in list a way to have a default library ?
I see in staff interface library is mandatory and the first in list is selected. Should we also add an empty line ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #5)
Makes sens.
But why not adding this empty value when branchcode is not mandatory ? Is selecting first in list a way to have a default library ?
It is particularity important to have an empty value when the branchcode is mandatory or else it defaults to the first value alphabetically and the user can leave it on the first value and the form will submit. The problem with having the empty value when branchcode is NOT mandatory is the user can submit the form without a branchcode and that causes an error upon submission. There must be a branchcode. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- So branchcode should always be in PatronSelfRegistrationBorrowerMandatoryField ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Fridolin Somers from comment #8)
So branchcode should always be in PatronSelfRegistrationBorrowerMandatoryField ?
It must be present on the form. It does not necessarily need to be mandatory but I suppose it could be. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30151 [Bug 30151] branchcode should always be in PatronSelfRegistrationBorrowerMandatoryField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK, I've opened Bug 30151 for that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.03 released in| | CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.12 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03,21.05.12 |22.05.00,21.11.03,21.05.13 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27601 CC| |tomjoefran@gmail.com --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 27601 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27601 [Bug 27601] Self registration form drop down list for libraries should require user interaction -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org